Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrink dialog size #38

Merged
merged 7 commits into from
Oct 21, 2024
Merged

Shrink dialog size #38

merged 7 commits into from
Oct 21, 2024

Conversation

piroor
Copy link
Member

@piroor piroor commented Oct 18, 2024

ダイアログの大きさを必要十分と思われるサイズに縮小する変更です。見た目の調整の出発点として必要と思って実装しました。

  • 最初に開くサイズを小さめにする
  • ダイアログの内容が確定した段階で、まだ余白が余るようであれば内容が溢れない範囲で縮小する
  • ダイアログを手動でリサイズした場合などに内容が溢れるときに、ダイアログ最下部のボタンだけは常に表示されるようにする

@piroor piroor requested a review from HashidaTKS October 18, 2024 04:13
Copy link
Contributor

@HashidaTKS HashidaTKS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HashidaTKS HashidaTKS merged commit 7d6dae5 into main Oct 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants