Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrink dialog size #38

Merged
merged 7 commits into from
Oct 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/web/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,11 @@ async function openDialog({ url, data, asyncContext, promptBeforeOpen, ...params
});
}

function charsToPercentage(chars, maxSize) {
const bodyFontSize = parseInt(window.getComputedStyle(document.body).fontSize);
return Math.floor(((bodyFontSize * chars) / maxSize) * 100);
}

async function tryConfirm(data, asyncContext) {
const { to, cc, bcc } = data.target;
const { trustedDomains, unsafeDomains } = data.config;
Expand All @@ -220,11 +225,11 @@ async function tryConfirm(data, asyncContext) {
}

const { status, asyncContext: updatedAsyncContext } = await openDialog({
url: window.location.origin + "/dialog.html",
url: window.location.origin + "/confirm.html",
data,
asyncContext,
height: 60,
width: 60,
height: Math.min(60, charsToPercentage(50, screen.availHeight)),
width: Math.min(80, charsToPercentage(45, screen.availWidth)),
});
console.debug("status: ", status);

Expand Down Expand Up @@ -263,8 +268,8 @@ async function tryCountDown(data, asyncContext) {
url: window.location.origin + "/count-down.html",
data,
asyncContext,
height: 60,
width: 60,
height: Math.min(20, charsToPercentage(15, screen.availHeight)),
width: Math.min(20, charsToPercentage(25, screen.availWidth)),
});
console.debug("status: ", status);

Expand Down
69 changes: 69 additions & 0 deletions src/web/confirm.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
.heading-container {
display: flex;
align-items: center;
}

.heading-container fluent-button {
margin-left: 10px;
}

.check-target {
margin-left: 20px;
display: flex;
margin-bottom: 10px;
}

#untrusted-domains fluent-checkbox::part(label) {
color: red;
}

#attachment-and-others fluent-checkbox.warning::part(label) {
color:red;
}

/* fluent-dialog {
--dialog-background-color: red;
background: red !important;
padding: 1.5em;
color: white !important;
font-size: x-large !important;
font-weight: bold !important;
text-align: center;
} */

fluent-dialog::part(control) {
color: white;
background-color: red;
padding: 0 1.5em 1.5em 1.5em;
text-align: center;
--dialog-width: fit-content;
--dialog-height: fit-content;
}

fluent-dialog::part(control) .newly-added-domain-content {
background-color: white;
background: var(--bg-color) !important;
}

fluent-dialog .newly-added-domain-content {
color: black;
padding: 2em;
text-align: left;
}

fluent-dialog .newly-added-domain-content strong {
font-size: large;
font-weight: bold;
}

#newly-added-domain-address-list {
margin: 1em 0;
}

#cancel-new-domain-button {
margin-left: 10px;
}

.new-domain-button-container {
margin-top: 20px;
}
43 changes: 23 additions & 20 deletions src/web/dialog.html → src/web/confirm.html
Original file line number Diff line number Diff line change
Expand Up @@ -7,29 +7,32 @@
<script src="https://appsforoffice.microsoft.com/lib/1/hosted/office.js" type="text/javascript" crossorigin="anonymous"></script>
<script src="https://code.jquery.com/jquery-3.7.1.min.js" integrity="sha256-/JqT3SQfawRcv/BIHPThkBvs0OEvtFFmqPF/lYI/Cxo=" crossorigin="anonymous"></script>
<link href="dialog.css" rel="stylesheet">
<link href="confirm.css" rel="stylesheet">
</head>
<body>
<div class="card-container">
<fluent-card>
<div class="heading-container">
<h3 data-l10n-text-content="confirmation_trustedCaption"></h3>
<fluent-button onclick="onCheckAllTrusted()"
data-l10n-text-content="confirmation_trustedCheckAllButtonLabel"></fluent-button>
</div>
<fluent-divider></fluent-divider>
<div id="trusted-domains">
</div>
</fluent-card>
<fluent-card>
<h3 data-l10n-text-content="confirmation_untrustedCaption"></h3>
<fluent-divider></fluent-divider>
<div id="untrusted-domains"></div>
</fluent-card>
<fluent-card>
<h3 data-l10n-text-content="confirmation_miscCaption"></h3>
<fluent-divider></fluent-divider>
<div id="attachment-and-others"></div>
</fluent-card>
<div class="cards">
<fluent-card>
<div class="heading-container">
<h3 data-l10n-text-content="confirmation_trustedCaption"></h3>
<fluent-button onclick="onCheckAllTrusted()"
data-l10n-text-content="confirmation_trustedCheckAllButtonLabel"></fluent-button>
</div>
<fluent-divider></fluent-divider>
<div id="trusted-domains">
</div>
</fluent-card>
<fluent-card>
<h3 data-l10n-text-content="confirmation_untrustedCaption"></h3>
<fluent-divider></fluent-divider>
<div id="untrusted-domains"></div>
</fluent-card>
<fluent-card>
<h3 data-l10n-text-content="confirmation_miscCaption"></h3>
<fluent-divider></fluent-divider>
<div id="attachment-and-others"></div>
</fluent-card>
</div>
<div class="button-container">
<fluent-button id="send-button" onclick="onSend()" disabled
data-l10n-text-content="confirmation_sendButtonLabel"></fluent-button>
Expand Down
3 changes: 3 additions & 0 deletions src/web/dialog.js → src/web/confirm.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { L10n } from "./l10n.mjs";
import { SafeBccConfirmation } from "./safe-bcc-confirmation.mjs";
import { AddedDomainsReconfirmation } from "./added-domains-reconfirmation.mjs";
import { AttachmentsConfirmation } from "./attachments-confirmation.mjs";
import * as Dialog from "./dialog.mjs";

let l10n;
let safeBccConfirmation;
Expand Down Expand Up @@ -174,6 +175,8 @@ async function onMessageFromParent(arg) {
)
);

Dialog.resizeToContent();

addedDomainsReconfirmation.init(data);
addedDomainsReconfirmation.initUI(sendStatusToParent);

Expand Down
16 changes: 0 additions & 16 deletions src/web/count-down.css
Original file line number Diff line number Diff line change
@@ -1,19 +1,3 @@
fluent-card {
margin-top: 20px;
padding-bottom: 20px;
padding-left: 10px;
padding-right: 10px;
}

#count {
font-size: x-large;
}

.button-container {
margin-top: 20px;
text-align: right;
}

#cancel-button {
margin-left: 10px;
}
15 changes: 9 additions & 6 deletions src/web/count-down.html
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,19 @@
<script src="https://unpkg.com/@fluentui/web-components" type="module"></script>
<script src="https://appsforoffice.microsoft.com/lib/1/hosted/office.js" type="text/javascript" crossorigin="anonymous"></script>
<script src="https://code.jquery.com/jquery-3.7.1.min.js" integrity="sha256-/JqT3SQfawRcv/BIHPThkBvs0OEvtFFmqPF/lYI/Cxo=" crossorigin="anonymous"></script>
<link href="dialog.css" rel="stylesheet">
<link href="count-down.css" rel="stylesheet">
</head>
<body>
<div class="card-container">
<fluent-card>
<p id="message" hidden>
<span data-l10n-text-content="countDown_messageBefore"></span>
<span id="count"></span>
<span data-l10n-text-content="countDown_messageAfter"></span></p>
</fluent-card>
<div class="cards">
<fluent-card>
<p id="message" hidden>
<span data-l10n-text-content="countDown_messageBefore"></span>
<span id="count"></span>
<span data-l10n-text-content="countDown_messageAfter"></span></p>
</fluent-card>
</div>
<div class="button-container">
<fluent-button id="send-button" onclick="onSend()"
data-l10n-text-content="countDown_sendButtonLabel"></fluent-button>
Expand Down
3 changes: 3 additions & 0 deletions src/web/count-down.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { L10n } from "./l10n.mjs";
import * as Dialog from "./dialog.mjs";

let l10n;

Expand Down Expand Up @@ -44,6 +45,8 @@ async function onMessageFromParent(arg) {
$("#count").text(data.config.common.CountSeconds);
$("#message").show();

Dialog.resizeToContent();

const start = Date.now();
const timer = window.setInterval(() => {
const rest = Math.ceil(data.config.common.CountSeconds - (Date.now() - start) / 1000);
Expand Down
84 changes: 17 additions & 67 deletions src/web/dialog.css
Original file line number Diff line number Diff line change
Expand Up @@ -9,86 +9,36 @@ fluent-divider {
margin: 1em 0;
}

.heading-container {
display: flex;
align-items: center;
}

.card-container {
margin-left: 20px;
margin-right: 20px;
}

.heading-container fluent-button {
margin-left: 10px;
}

.check-target {
margin-left: 20px;
display: flex;
margin-bottom: 10px;
flex-direction: column;
height: 100%;
left: 0;
position: fixed;
top: 0;
width: 100%;
}

#untrusted-domains fluent-checkbox::part(label) {
color: red;
.cards,
.button-container {
padding-left: 20px;
padding-right: 20px;
}

#attachment-and-others fluent-checkbox.warning::part(label) {
color:red;
.cards {
align-items: stretch;
display: flex;
flex-flow: column;
justify-content: flex-start;
overflow: auto;
}

.button-container {
padding-bottom: 10px;
margin-top: 20px;
text-align: right;
}

#cancel-button {
margin-left: 10px;
}

/* fluent-dialog {
--dialog-background-color: red;
background: red !important;
padding: 1.5em;
color: white !important;
font-size: x-large !important;
font-weight: bold !important;
text-align: center;
} */

fluent-dialog::part(control) {
color: white;
background-color: red;
padding: 0 1.5em 1.5em 1.5em;
text-align: center;
--dialog-width: fit-content;
--dialog-height: fit-content;
}

fluent-dialog::part(control) .newly-added-domain-content {
background-color: white;
background: var(--bg-color) !important;
}

fluent-dialog .newly-added-domain-content {
color: black;
padding: 2em;
text-align: left;
}

fluent-dialog .newly-added-domain-content strong {
font-size: large;
font-weight: bold;
}

#newly-added-domain-address-list {
margin: 1em 0;
}

#cancel-new-domain-button {
margin-left: 10px;
}

.new-domain-button-container {
margin-top: 20px;
}
16 changes: 16 additions & 0 deletions src/web/dialog.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
/*
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
"use strict";

export function resizeToContent() {
const range = document.createRange();
range.selectNodeContents(document.querySelector(".card-container"));
const contentsRect = range.getBoundingClientRect();

const widthDelta = contentsRect.width - window.innerWidth;
const heightDelta = contentsRect.height - window.innerHeight;
window.resizeBy(Math.min(0, widthDelta), Math.min(0, heightDelta));
}
8 changes: 4 additions & 4 deletions webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ module.exports = async (env, options) => {
entry: {
polyfill: ["core-js/stable", "regenerator-runtime/runtime"],
app: ["./src/web/app.js"],
dialog: ["./src/web/dialog.js"],
confirm: ["./src/web/confirm.js"],
"count-down": ["./src/web/count-down.js"],
},
output: {
Expand Down Expand Up @@ -83,9 +83,9 @@ module.exports = async (env, options) => {
],
}),
new HtmlWebpackPlugin({
filename: "dialog.html",
template: "./src/web/dialog.html",
chunks: ["polyfill", "dialog"],
filename: "confirm.html",
template: "./src/web/confirm.html",
chunks: ["polyfill", "confirm"],
}),
new HtmlWebpackPlugin({
filename: "count-down.html",
Expand Down