-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated render classes #3773
Conversation
It looks like the GT++ ores are causing double-tesselation-draw issues. I'm not sure why it's only happening for some people, but it looks like Alternatively, you could yoink my rendering changes from my ore PR which removes the GT++ and BW ISBRHs entirely (though it isn't in a specific commit, so you'd need to find each change any copy it). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't add a suggested changes since you haven't edited CustomOreBlockRenderer, but I've confirmed that the above patch fixes the rendering issues with gt++ ores. The ores are causing crashes and severe lag in AE terminals (likely due to caught exceptions).
@RecursivePineapple Could you take another look at this PR? I believe I fixed the issue with the GT++ ore renderer @Dream-Master This PR should be good for another round of zeta testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My concerns have been addressed.
I'll approve this since the only feasible way to test it is by scream testing in the nightlies.
Migrates all the loose ends to TextureFactory.
Also has the side effect of giving glow textures to the Atmospheric Cleaner and Auto-Chisel (singleblocks).
I checked the organization with github search and did not see any further usages of these now removed classes.
Closes GTNewHorizons/GT-New-Horizons-Modpack#18762