Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magic Apiary Texture Rework + Fix Research #32

Closed
wants to merge 6 commits into from
Closed

Magic Apiary Texture Rework + Fix Research #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a61cb36
Expands Icon width for Texture pack compat
DrParadox7 Nov 4, 2021
7d46c3f
Fix research langs
DrParadox7 Jul 21, 2022
776d742
GUI Rework
DrParadox7 Oct 17, 2023
2c1ba05
Make DNA icon more runic
DrParadox7 Dec 13, 2023
8331522
Shading
DrParadox7 Dec 13, 2023
2ba683d
Merge branch 'master' into GTNH-PR
Dream-Master Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/magicbees/client/gui/GuiMagicApiary.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,14 @@ public class GuiMagicApiary extends GuiContainer {
private static final int WORKBOOST_SRC_X = 176;
private static final int WORKBOOST_SRC_Y = 46;

private static final int DEATHBOOST_WIDTH = 11;
private static final int DEATHBOOST_WIDTH = 13;
private static final int DEATHBOOST_HEIGHT = 13;
private static final int DEATHBOOST_DEST_X = 25;
private static final int DEATHBOOST_DEST_Y = 17;
private static final int DEATHBOOST_SRC_X = 176;
private static final int DEATHBOOST_SRC_Y = 58;

private static final int MUTATIONBOOST_WIDTH = 9;
private static final int MUTATIONBOOST_WIDTH = 10;
private static final int MUTATIONBOOST_HEIGHT = 13;
private static final int MUTATIONBOOST_DEST_X = 15;
private static final int MUTATIONBOOST_DEST_Y = 17;
Expand Down
Binary file modified src/main/resources/assets/magicbees/textures/gui/apiary.png
View file
Open in desktop
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a mixture is nice. (gui saty icons changed) The new icons much cleaner expain where they stand for

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a mixture is nice. (gui saty icons changed) The new icons much cleaner expain where they stand for

I'm strongly against any change in this specific case, Magic Bees has a very unique style of design, and any removal from that is a downright tragedy, the icons as they are fit perfectly into the style Magic Bees has portrayed within the entirety of itself, and if you've done the mod, you understand what the icons mean.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But if he wants to put a proper side by side, he's free to do so, no PR that changes icons should be passed if they don't even at the very least do that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure lets hear more people on this

Copy link

@Alastors Alastors Oct 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apiary1
besides are you telling me this

makes less sense than this:
apiary2

They're both downright nonsensical, so it literally doesn't matter if they're "more readable" because they're both downright unreadable, a change just strips identity for 0 gain.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Magic ain't technology no matter what some old sci-fi authors say. I say unique GUIs for the magical things is nice.

A gregtech style GUI should be for the beecompressor9000™ or some other technological disaster, not magic,

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.