Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magic Apiary Texture Rework + Fix Research #32

Closed
wants to merge 6 commits into from

Conversation

DrParadox7
Copy link

Retextures Apiary GUI to the same style as Forestry's Bee Houses with enhanced clarity for icons:

Increased Production:
image
Decreased Lifespan:
image
Increased Mutation:
image

Also fixed Research langs not correctly localized.

@Dream-Master Dream-Master requested a review from a team October 17, 2023 18:25
Copy link

@Alastors Alastors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not change the texture of the GUI

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a mixture is nice. (gui saty icons changed) The new icons much cleaner expain where they stand for

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a mixture is nice. (gui saty icons changed) The new icons much cleaner expain where they stand for

I'm strongly against any change in this specific case, Magic Bees has a very unique style of design, and any removal from that is a downright tragedy, the icons as they are fit perfectly into the style Magic Bees has portrayed within the entirety of itself, and if you've done the mod, you understand what the icons mean.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But if he wants to put a proper side by side, he's free to do so, no PR that changes icons should be passed if they don't even at the very least do that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure lets hear more people on this

Copy link

@Alastors Alastors Oct 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apiary1
besides are you telling me this

makes less sense than this:
apiary2

They're both downright nonsensical, so it literally doesn't matter if they're "more readable" because they're both downright unreadable, a change just strips identity for 0 gain.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Magic ain't technology no matter what some old sci-fi authors say. I say unique GUIs for the magical things is nice.

A gregtech style GUI should be for the beecompressor9000™ or some other technological disaster, not magic,

@Alastors
Copy link

The Magic Bees Apiary is a unique bit of thaumcraft, do not sully it by unifying textures when it is already so unique.

This PR as a whole is a reflection of someone who doesn't understand the vibrant uniqueness that each thaum addon brings to the table that is design.

Each texture, a kiss of specific style, a small impression of who the dev was, this is just sad.

@Prometheus0000
Copy link
Member

I agree with alastor, there's no reason to change the icons. Maybe the background, but I don't really think that needs changing either. If the author wanted it to use 'Forestry's Bee House icons' (which I don't recall ever seeing BTW) they would have used them.

@Alastors
Copy link

apiary
I'd like to bring to focus one final thing as well, base forestry doesn't have icons, so these icons are entirely unique to the Magic Apiary

@SilearFlare
Copy link

SilearFlare commented Oct 17, 2023

While you're at it, I'll pop in since the repo doesn't have any issues to actually start a discussion in and Alastor already did the same change between Gregapi and gregtech in https://github.com/GTNewHorizons/ThaumicHorizons/tree/gt6-gix, as mentioned in GTNewHorizons/ThaumicHorizons#46, a specific commit in magic bees, specifically d9ef30f crashes the modpack and using any version of magic bees alongside any version of gregtech outside of 5U causes a crash.

At least in the case of thaumic horizons it was just a matter of enabling an external config which is disabled by default, in this case the mod just crashes with no option to do anything about it. and as it is, is impossible to play any version of magic bees past that commit.

Oh also the new icons are cool and I personally think as an external observer that they should be changed 👍

@DrParadox7
Copy link
Author

These review are charming if not for their touch of creative flair.
MysteriousAges would appreciate a cleanup of Magic Bees' most cryptic aspect, especially after over a decade from its inception.

As a talented programmer artist yourself I get the apprehension, but when it comes to user interfaces, the ultimate aim should be making them feel cohesive and user-friendly which the original could use some improvement.

Anyways, you've asked for a comparison so here are the gifs (compression may slightly alter the colors).

Old:
Magic Apiary Animation-old

New:
Magic Apiary Animation-new

Things have been slightly tweaked in my latest iteration which is not included here but is available on request.

@Alastors
Copy link

Alastors commented Oct 18, 2023

MysteriousAges would appreciate a cleanup of Magic Bees' most cryptic aspect, especially after over a decade from its inception.

Who is MysteriousAges?
NVM you mean one of the devs, I fully invite him to come here and say the same then, though I would still disagree with that opinion personally. Of course that considered, he could just re-release the mod himself, given he still has ownership.

As a talented programmer artist yourself I get the apprehension, but when it comes to user interfaces, the ultimate aim should be making them feel cohesive and user-friendly which the original could use some improvement.

Ehhhhhhhhhh, not so much with Thaumcraft, the majority of Thaumcraft consistently and intentionally keeps the UI user-unfriendly and enigmatic for various reasons, and it's important to stay consistent with that design goal, though this system is one of the less enigmatic given that the Thaumonomicon directly lists out what each of them mean. Though I hardly believe a full rework of the GUI itself is tantamount to making it any more "user friendly" you could make the argument for the icons sure, but personally, I don't think there is enough value here to justify the utter destruction of the original GUI in totality.

@Alastors
Copy link

Alastors commented Oct 18, 2023

Screen Shot 2023-10-17 at 8 06 04 PM

MysteriousAges would appreciate a cleanup of Magic Bees' most cryptic aspect, especially after over a decade from its inception.

Given there's been no update to Magic Bees in over 3 years though, I hardly believe you speak for MysteriousAges.

@Connor-Colenso
Copy link

Thanks for the rework, this second iteration looks much better imo.

@mitchej123
Copy link

I like the second iteration of the GUI.

The icons seem slightly out of place for magic (at least the DNA one)

@Dream-Master
Copy link
Member

i like to see it with bees ingame. How the bees look like on nearly black backround?

@DrParadox7
Copy link
Author

DrParadox7 commented Oct 18, 2023

i like to see it with bees ingame. How the bees look like on nearly black backround?

Sure, I can do that:
in-use

@Dream-Master
Copy link
Member

ok thanks for showing. I think the hexagons need to be more visible and also the slots.

@DrParadox7
Copy link
Author

DrParadox7 commented Oct 18, 2023

The icons seem slightly out of place for magic (at least the DNA one)

I reluctantly agree with the sentiment.
That DNA is definitely the weaker element of this design.

It can be difficult to translate science elements such as genetic mutation into a magic theme.

I originally aimed to infuse a touch of alchemy, inspired by Fullmetal Alchemist/The Witcher 3 but I soon realized that this was quite a tough task, not just design-wise with a limited 10-pixel width canvas, but also in making sure it's easy to understand and use for everyone.

What you see is what I have settled on for lack of a better solution.

@Alastors
Copy link

After hours of stringent and fervent debate, we have now updated our dev Code of Conduct, and thusly, I push forth that this PR breaks GTNH CoC 7-1 given how this proposal would shift the identity significantly too far away from the unique feel intended by magic within the pack, likewise, the alternative modification proposed in #meta-dev can be handled by GTNH CoC 7-4

  1. Regarding textures within GTNH
    1. Regarding magic textures: within the vision of the modpack, magic is meant to feel, look, and be different than GregTech, any form of GUI update for the sake of (or that would inadvertently bring) consistency with GT GUIs should be rejected.
    2. n/a
    3. n/a
    4. Regarding inventory changing: GUIs that shift the colour of the player's internal inventory are allowed as long as its usage is consistent. Examples being: GT's Steam Machines, Magic Bee's Magic Apiary, Railcraft's Coke Oven, etc.

@DrParadox7
Copy link
Author

ok thanks for showing. I think the hexagons need to be more visible and also the slots.

I covered your valid concern.
There were also a couple of other issues fixed with it:

@DrParadox7
Copy link
Author

@Alastors If you've already altered the rules to predetermine the outcome of this PR, there's no need for further opinions.
Enforcing your authority to conclude this discussion should be just as easy.

@SilearFlare
Copy link

Kinda defeats the whole point of having a discussion if ya can simply edit the rules to what can be done and can't be done mid-discussion, doesn't it? But then again I'm just here to point the issue with magic bees crashing with gt6 anyway :^)

@OneEyeMaker
Copy link

OneEyeMaker commented Oct 20, 2023

@DrParadox7 New UI looks nice. But what about to recolor/tint light grey part of new UI to make it more unique? (with color of Greatwood/Arcane stone/Thaumium)

@bombcar
Copy link
Member

bombcar commented Oct 20, 2023

This still looks like a GT machine to me - not really what I'd want, but I've not done bees or magic this far.

@Alastors
Copy link

Kinda defeats the whole point of having a discussion if ya can simply edit the rules to what can be done and can't be done mid-discussion, doesn't it? But then again I'm just here to point the issue with magic bees crashing with gt6 anyway :^)

The new ruling came after tireless debate for 2 days straight, that's literally the point of having rules, make rules when new issues come up.

@Alastors
Copy link

This still looks like a GT machine to me - not really what I'd want, but I've not done bees or magic this far.

This is the entire issue, it defaces Magic's identity for no real reason

@Alastors
Copy link

Alastors commented Oct 20, 2023

@DrParadox7 New UI looks nice. But what about to recolor/tint light grey part of new UI to make it more unique? (with color of Greatwood/Arcane stone/Thaumium)

There were also concern in those debates (not even mostly by me) that the icons look too "techy" compared to what the original looked like

@boubou19
Copy link
Member

boubou19 commented Dec 4, 2023

what do we do with this PR?

@Alastors
Copy link

Alastors commented Dec 4, 2023

what do we do with this PR?

It was rejected, and the CoC was changed to reflect it

@Dream-Master
Copy link
Member

We discuss it after stable

@Alastors
Copy link

Alastors commented Dec 6, 2023

We discuss it after stable

https://github.com/GTNewHorizons/GTNH-Dev-Doc/blob/master/developer's%20code%20of%20conduct.md

Dream, respectfully we wasted too long on and off discussing this exact topic, please do not waste developer time further on such tripe like this. However, I will remind you of our policies regarding this topic now:

Code of Conduct

Subsection 3: Content Creation

  1. Regarding textures within GTNH
    7-1. Regarding magic textures: within the vision of the modpack, magic is meant to feel, look, and be different than GregTech, any form of GUI update for the sake of (or that would inadvertently bring) consistency with GT GUIs should be rejected.
    7-2. Regarding new textures: try to keep textures consistent with the mod/mod group they're being added to.
    7-3. Regarding tooltips: reduction is fine when needed, but if there is a specific consistency, try to stay within that.
    7-4. Regarding inventory changing: GUIs that shift the colour of the player's internal inventory are allowed as long as its usage is consistent. Examples being: GT's Steam Machines, Magic Bee's Magic Apiary, Railcraft's Coke Oven, etc.

I cannot stress this further, please do not waste any more of our time on meaningless debate on aesthetic taste, it gets incredibly argumentative, chaotic, downright rude, and quite frankly it's bad for developer moral on the pack. This has already been settled, we need to leave it in the past where it belongs.

Besides, even out of all the debate, no one actually cared for this specific UI, the most anyone actually cared about were the Icons or the rare desire to split the original UI instead.

@Connor-Colenso
Copy link

Stating this as a violation of the CoC makes no sense, the mod contains 3 GUIs, 2 of which are vanilla esque, see https://github.com/GTNewHorizons/MagicBees/blob/master/src/main/resources/assets/magicbees/textures/gui/jarScreen.png and https://github.com/GTNewHorizons/MagicBees/blob/master/src/main/resources/assets/magicbees/textures/gui/ringScreen.png and the third is this strange shaded variant.

So arguably this PR actually brings it fully in line with the CoC by giving the same shading to all GUIs?

@Caedis
Copy link
Member

Caedis commented Dec 6, 2023

The color of the new GUI definitely feels too much like a GT/Vanilla one. I say we keep the old color of the gui, but apply that to all of Magic Bee's guis

@Alastors
Copy link

Alastors commented Dec 6, 2023

Stating this as a violation of the CoC makes no sense, the mod contains 3 GUIs, 2 of which are vanilla esque, see https://github.com/GTNewHorizons/MagicBees/blob/master/src/main/resources/assets/magicbees/textures/gui/jarScreen.png and https://github.com/GTNewHorizons/MagicBees/blob/master/src/main/resources/assets/magicbees/textures/gui/ringScreen.png and the third is this strange shaded variant.

So arguably this PR actually brings it fully in line with the CoC by giving the same shading to all GUIs?

The bee ring and jar one are intentionally clones of each other, also the bee ring is not exactly in optimal shape, frankly I'm not sure if it actually has a recipe but using them as an example of two separate GUIs is very deceptive

@Steelux8
Copy link

Steelux8 commented Dec 7, 2023

The only problem I see here is that a DNA icon doesn't really fit magic content. Other than that, I look at the screenshots and what I think is Forestry bees with a touch of flair and a starry background that makes me think of Astral Sorcery, which is a magic mod. It overall looks fine to me, and I didn't really see it as a GT GUI the moment I looked at it.

@DrParadox7
Copy link
Author

DrParadox7 commented Dec 9, 2023

The only problem I see here is that a DNA icon doesn't really fit magic content. Other than that, I look at the screenshots and what I think is Forestry bees with a touch of flair and a starry background that makes me think of Astral Sorcery, which is a magic mod. It overall looks fine to me, and I didn't really see it as a GT GUI the moment I looked at it.

@Steelux8 I agree.
This was the original concept for the DNA symbol but I had given up on it as it proved to be too difficult to conceptualize it into pixel art (too tiny canvas size and awkward angles):
image
Feel free to have a go at it

@DrParadox7
Copy link
Author

Made alterations to look less DNA-y and more runic (based on the Inguz rune shown above).
It should be satisfactory enough without compromising clarity.
image

@Dream-Master Dream-Master added ongoing freeze - don't merge Not just a bug fix and thus affected by a current freeze for a upcoming version and removed ongoing freeze - don't merge Not just a bug fix and thus affected by a current freeze for a upcoming version labels Dec 14, 2023
@miaowwwwww
Copy link
Member

tbh, i like the three new texture, how about just keep everything else, only update the 3 pics. i like the brown background and purple linings.

@DrParadox7
Copy link
Author

It has been over 6 months and I am no longer interested in making further changes.

I thank those who left some kind words and those that offered constructive criticism.
The discussion was mostly met with scorn and bureaucratic coercion and my enthusiasm is simply not there anymore to offset it.

The GUI definitely needs some clarity, just come up with your own original reimaginations without use of my work.
As for the players who wanted my rework in GTNH I can release it as a separate texture pack should there be an interest in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.