Bugfix #93
Closed
Bugfix #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are many sign conversions (safe) to refactor the code.
HalosGhost
requested changes
Oct 15, 2018
There was a problem hiding this comment.
Any casting needs to be handled explicitly. Disabling -Werror is not acceptable.
The rest of the code is definitely a good start. However, as the immediate motivation for this change is to fix stdin-pasting, I would not say it is ready for merge yet. When that case is handled and it builds cleanly, we will be all set!
Thank you for looking at this!
|
As the entire motivation for this branch was making it work smoothly with ptpb which is dead (ptpb/pb#246), I'd no longer be working on the project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.