refactor(p2p): async on_new_vertex [part ?] #1155
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## refactor/p2p/remove-manager #1155 +/- ##
===============================================================
- Coverage 84.59% 84.50% -0.10%
===============================================================
Files 320 321 +1
Lines 24474 24480 +6
Branches 3751 3746 -5
===============================================================
- Hits 20705 20686 -19
- Misses 3056 3074 +18
- Partials 713 720 +7 ☔ View full report in Codecov by Sentry. |
glevco
changed the title
glevco
force-pushed
the
refactor/p2p/remove-manager
branch
from
1d77698 to
b204c2c
Compare
glevco
force-pushed
the
refactor/p2p/async-on-new-vertex
branch
from
67866a6 to
f3a5c96
Compare
glevco
force-pushed
the
refactor/p2p/remove-manager
branch
from
b204c2c to
2af3b11
Compare
glevco
force-pushed
the
refactor/p2p/async-on-new-vertex
branch
from
f3a5c96 to
2c9988d
Compare
1 task
glevco
changed the title
glevco
changed the title
glevco
force-pushed
the
refactor/p2p/remove-manager
branch
9 times, most recently
from
10c2ec4 to
b6b19b2
Compare
glevco
changed the title
glevco
force-pushed
the
refactor/p2p/remove-manager
branch
from
b6b19b2 to
58633dc
Compare
glevco
force-pushed
the
refactor/p2p/remove-manager
branch
3 times, most recently
from
45ede7d to
bf1e568
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1142
Motivation
For the P2P Multiprocess project, the
on_new_vertexmethod will be called in the node main process from the P2P subprocess via IPC. This call will beasync, so this PR refactors the callers of this method to support it.Acceptance Criteria
P2PDependencies.on_new_vertextoasync, bubbling it up to all its callers.twisted.call_coro_laterutils function.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged