Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(p2p): rename ConnectionsManager to P2PManager [part ?] #1158

Draft
wants to merge 1 commit into
base: refactor/p2p/async-on-new-vertex
Choose a base branch
from

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Oct 15, 2024

Depends on #1155

Motivation

What was the motivation for the changes in this PR?

Acceptance Criteria

  • Include here all things that this PR should solve

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Oct 15, 2024
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 81.57895% with 14 lines in your changes missing coverage. Please review.

Please upload report for BASE (refactor/p2p/async-on-new-vertex@2c9988d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
hathor/sysctl/p2p/manager.py 78.78% 5 Missing and 2 partials ⚠️
hathor/p2p/states/peer_id.py 40.00% 0 Missing and 3 partials ⚠️
hathor/builder/sysctl_builder.py 0.00% 1 Missing ⚠️
hathor/p2p/protocol.py 85.71% 0 Missing and 1 partial ⚠️
hathor/p2p/states/hello.py 50.00% 0 Missing and 1 partial ⚠️
hathor/p2p/states/ready.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@                         Coverage Diff                         @@
##             refactor/p2p/async-on-new-vertex    #1158   +/-   ##
===================================================================
  Coverage                                    ?   84.50%           
===================================================================
  Files                                       ?      321           
  Lines                                       ?    24461           
  Branches                                    ?     3743           
===================================================================
  Hits                                        ?    20670           
  Misses                                      ?     3071           
  Partials                                    ?      720           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco changed the title refactor(p2p): rename ConnectionsManager to P2PManager refactor(p2p): rename ConnectionsManager to P2PManager [part 7/7] Oct 15, 2024
@glevco glevco force-pushed the refactor/p2p/async-on-new-vertex branch from 67866a6 to f3a5c96 Compare October 15, 2024 20:23
@glevco glevco force-pushed the refactor/p2p/renames branch from ff5124f to ec8c2eb Compare October 15, 2024 20:28
@glevco glevco force-pushed the refactor/p2p/async-on-new-vertex branch from f3a5c96 to 2c9988d Compare October 15, 2024 20:32
@glevco glevco force-pushed the refactor/p2p/renames branch from ec8c2eb to ae318ec Compare October 15, 2024 20:32
@glevco glevco changed the title refactor(p2p): rename ConnectionsManager to P2PManager [part 7/7] refactor(p2p): rename ConnectionsManager to P2PManager [part 7/8] Oct 15, 2024
@glevco glevco changed the title refactor(p2p): rename ConnectionsManager to P2PManager [part 7/8] refactor(p2p): rename ConnectionsManager to P2PManager [part 8/8] Oct 22, 2024
@glevco glevco changed the title refactor(p2p): rename ConnectionsManager to P2PManager [part 8/8] refactor(p2p): rename ConnectionsManager to P2PManager [part ?] Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

1 participant