refactor(p2p): implement P2PConnectionProtocol [part 9/11] #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glevco
force-pushed
the
refactor/p2p/p2p-connection-protocol
branch
from
1bb16b8 to
2034c11
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## refactor/p2p/initial-state #1166 +/- ##
==============================================================
- Coverage 84.87% 84.73% -0.15%
==============================================================
Files 321 318 -3
Lines 24498 24508 +10
Branches 3728 3742 +14
==============================================================
- Hits 20792 20766 -26
- Misses 2987 3000 +13
- Partials 719 742 +23 ☔ View full report in Codecov by Sentry. |
glevco
force-pushed
the
refactor/p2p/p2p-connection-protocol
branch
from
bb266e3 to
cc3bba3
Compare
Open
1 task
glevco
force-pushed
the
refactor/p2p/p2p-connection-protocol
branch
2 times, most recently
from
72d3563 to
f7bf2f2
Compare
glevco
force-pushed
the
refactor/p2p/remove-manager
branch
from
b6b19b2 to
58633dc
Compare
glevco
force-pushed
the
refactor/p2p/p2p-connection-protocol
branch
from
f7bf2f2 to
c66b07d
Compare
glevco
changed the title
glevco
changed the base branch from
refactor/p2p/remove-manager
to
refactor/p2p/initial-state
glevco
force-pushed
the
refactor/p2p/p2p-connection-protocol
branch
3 times, most recently
from
08328b2 to
b4f9b18
Compare
glevco
commented
Nov 6, 2024
| @@ -340,11 +344,11 @@ def send_tx_to_peers(self, tx: BaseTransaction) -> None: | |||
| connections = list(self.iter_ready_connections()) | |||
| self.rng.shuffle(connections) | |||
| for conn in connections: | |||
| conn.send_tx_to_peer(tx) | |||
| self.reactor.callLater(0, conn.send_tx_to_peer, tx) | |||
There was a problem hiding this comment.
Changed this to unblock the main loop
Comment on lines
+366
to
+367
| protocol = self._connections.get_peer_by_address(addr) | ||
| self.reactor.callLater(0, protocol.disconnect, force=True) |
There was a problem hiding this comment.
Changed this to unblock the main loop
glevco
changed the title
glevco
force-pushed
the
refactor/p2p/initial-state
branch
from
a5399b5 to
260d851
Compare
glevco
force-pushed
the
refactor/p2p/p2p-connection-protocol
branch
from
b4f9b18 to
44e6db9
Compare
glevco
force-pushed
the
refactor/p2p/initial-state
branch
from
260d851 to
36da2f5
Compare
glevco
force-pushed
the
refactor/p2p/p2p-connection-protocol
branch
from
44e6db9 to
73b394a
Compare
glevco
changed the title
glevco
force-pushed
the
refactor/p2p/initial-state
branch
from
36da2f5 to
659806b
Compare
glevco
force-pushed
the
refactor/p2p/p2p-connection-protocol
branch
from
73b394a to
cb9f709
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1172
Motivation
Continuing with the multiprocess P2P implementation, this PR abstracts the last piece of code that binds individual P2P connections to the rest of the full node: calls from the
ConnectionsManagertoHathorProtocolinstances.It also adds the currently unimplemented
--x-multiprocess-p2pCLI option, and removes theSyncAgentFactoryabstraction, which was only necessary for Sync-v1 but not for Sync-v2. I refactored it to remove theConnectionsManager.get_sync_factorymethod, which couldn't be called through IPC.Acceptance Criteria
P2PConnectionProtocol, abstracting calls from theConnectionsManagerto individual connections (instances ofHathorProtocol).--x-multiprocess-p2pCLI option (currently does nothing).SyncAgents to removeConnectionsManager.get_sync_factory, also removing related classes.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged