Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix CI flaky tests #585

Closed
wants to merge 20 commits into from
Closed

tests: fix CI flaky tests #585

wants to merge 20 commits into from

Conversation

pedroferreira1
Copy link
Member

Acceptance Criteria

  • Include here all things that this PR should solve

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (217797f) 64.86% compared to head (4e52796) 78.29%.

Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #585       +/-   ##
===========================================
+ Coverage   64.86%   78.29%   +13.43%     
===========================================
  Files          67       67               
  Lines        5254     5257        +3     
  Branches     1108     1108               
===========================================
+ Hits         3408     4116      +708     
+ Misses       1766     1126      -640     
+ Partials       80       15       -65     
Files Coverage Δ
src/new/wallet.js 95.63% <100.00%> (+54.82%) ⬆️
src/storage/leveldb/store.ts 92.17% <100.00%> (+4.34%) ⬆️
src/storage/memory_store.ts 96.75% <100.00%> (+6.48%) ⬆️
src/types.ts 33.33% <ø> (ø)

... and 21 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pedroferreira1 pedroferreira1 self-assigned this Oct 30, 2023
@pedroferreira1 pedroferreira1 changed the title test log tests: fix CI flaky tests Oct 30, 2023
@r4mmer r4mmer mentioned this pull request Nov 3, 2023
1 task
@pedroferreira1
Copy link
Member Author

This PR was split into others: #589 and #590

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant