Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Composer Support #10

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

oPinqzz
Copy link

@oPinqzz oPinqzz commented Nov 26, 2024

The Library Still Works Until Today, I'm Using It, and Added Composer and Virion V3 Support, I Hope You accept the Merge

@HimbeersaftLP
Copy link
Owner

Hi, thanks for the PR!
As far as I understand, isn't the vendor directory supposed to not be on git (https://getcomposer.org/doc/faqs/should-i-commit-the-dependencies-in-my-vendor-directory.md), though?

@oPinqzz
Copy link
Author

oPinqzz commented Nov 26, 2024

Hi, thanks for the PR! As far as I understand, isn't the vendor directory supposed to not be on git (https://getcomposer.org/doc/faqs/should-i-commit-the-dependencies-in-my-vendor-directory.md), though?

Yeah, I forgot to remove it as I made composer init

@HimbeersaftLP
Copy link
Owner

You can make a gitignore file and put the folder name into it, that way it can't be commited accidentially

@oPinqzz
Copy link
Author

oPinqzz commented Nov 27, 2024

You can make a gitignore file and put the folder name into it, that way it can't be commited accidentially

Done,
And added virion.yml

@HimbeersaftLP
Copy link
Owner

You're supposed to create a text file called .gitignore and in that text file write the name of the folder(s) to be excluded. In your case you would probably also have to delete the existing files from the git repository beforehand.

@oPinqzz
Copy link
Author

oPinqzz commented Nov 28, 2024

You're supposed to create a text file called .gitignore and in that text file write the name of the folder(s) to be excluded. In your case you would probably also have to delete the existing files from the git repository beforehand.

I removed them from the repo

@oPinqzz
Copy link
Author

oPinqzz commented Dec 3, 2024

@HimbeersaftLP are you still there buddy ?

@HimbeersaftLP
Copy link
Owner

@iAbdo2008 Sorry I am very busy irl at the moment. It looks fine to me now, so I will merge it as soon as I have the time to register an account on Packagist.

@oPinqzz
Copy link
Author

oPinqzz commented Dec 6, 2024

@iAbdo2008 Sorry I am very busy irl at the moment. It looks fine to me now, so I will merge it as soon as I have the time to register an account on Packagist.

@HimbeersaftLP
I have added it to packgist a while about 2-5 months ago as i needed to use it :))

@HimbeersaftLP
Copy link
Owner

@iAbdo2008 Yeah, I just have to register my own account because otherwise I can't create a package from my repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants