Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffmpeg 4.0, mpv 0.28.2 #26882

Closed
wants to merge 14 commits into from
Closed

ffmpeg 4.0, mpv 0.28.2 #26882

wants to merge 14 commits into from

Conversation

ilovezfs
Copy link
Contributor

Created with brew bump-formula-pr.

@ilovezfs
Copy link
Contributor Author

CC @zmwangx

@ilovezfs ilovezfs force-pushed the ffmpeg-4.0 branch 3 times, most recently from 1d2d273 to bb3d124 Compare April 20, 2018 16:17
Copy link
Contributor Author

@ilovezfs ilovezfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not announced yet.

https://www.ffmpeg.org/

@zmwangx
Copy link
Contributor

zmwangx commented Apr 20, 2018

I think It shouldn't be remotely as disruptive as 3.0, but we'll see.

@retokromer
Copy link
Contributor

@ilovezfs FYI: It’s announced now.

@zshbleaker
Copy link

Noticed version 4.0 is not updated yet and came here to check if there's a PR. Wish it could be merged soon.

@zmwangx As a alumnus of NSFZ 2012, 久仰大名😄

@ilovezfs
Copy link
Contributor Author

@zmwangx there are build failures for gifski, mgba, opencv@2, openimageio, and qcli.

@ilovezfs
Copy link
Contributor Author

ilovezfs commented Apr 21, 2018

gifski reported here meh/rust-ffmpeg#112 and here ImageOptim/gifski#38

@ilovezfs
Copy link
Contributor Author

mgba is already fixed, so we can update it #26914

@ilovezfs
Copy link
Contributor Author

opencv was fixed in opencv/opencv#10011 but it was not backported to opencv@2 (the 2.4 branch). I've commented here: opencv/opencv#10011 (comment)

@ilovezfs
Copy link
Contributor Author

openimageio reported here AcademySoftwareFoundation/OpenImageIO#1923

@ilovezfs
Copy link
Contributor Author

ilovezfs commented Apr 21, 2018

qcli was fixed in HEAD (bavc/qctools@e83d7ad) but there's no release with the fix yet.

I've requested a release in bavc/qctools#538.
However, there's an unrelated build failure on OS X 10.11 case-sensitive file systems bavc/qctools#539

@ilovezfs ilovezfs force-pushed the ffmpeg-4.0 branch 2 times, most recently from bbf097f to 1b4d410 Compare April 21, 2018 15:03
@ilovezfs ilovezfs changed the title ffmpeg 4.0 ffmpeg 4.0, ffmpeg@3 3.4.2 (new formula) Apr 21, 2018
@ilovezfs ilovezfs changed the title ffmpeg 4.0, ffmpeg@3 3.4.2 (new formula) ffmpeg 4.0 Apr 21, 2018
@ilovezfs
Copy link
Contributor Author

Expecting qcli to be the sole failure, which isn't sufficient reason to block this upgrade or to add a versioned ffmpeg@3 formula.

@ilovezfs
Copy link
Contributor Author

also bumping mpv to 0.28.2 as long as we're here

@ilovezfs ilovezfs changed the title ffmpeg 4.0 ffmpeg 4.0, mpv 0.28.2 Apr 21, 2018
@ilovezfs
Copy link
Contributor Author

@BrewTestBot test this please

@ilovezfs ilovezfs closed this in a7837ee Apr 22, 2018
@scpeters
Copy link
Member

Sorry I didn't notice this before it got merged (need to add this to my email filters). I have compilation errors in some formulae in a 3rd-party tap. If there was an ffmpeg@3 formula, I'd try using that now, but since there's not, I'll just try to fix the compilation errors when I get a chance tomorrow.

@lock lock bot added the outdated PR was locked due to age label May 22, 2018
@lock lock bot locked as resolved and limited conversation to collaborators May 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants