-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ffmpeg 4.0, mpv 0.28.2 #26882
ffmpeg 4.0, mpv 0.28.2 #26882
Conversation
CC @zmwangx |
1d2d273
to
bb3d124
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not announced yet.
I think It shouldn't be remotely as disruptive as 3.0, but we'll see. |
@ilovezfs FYI: It’s announced now. |
Noticed version 4.0 is not updated yet and came here to check if there's a PR. Wish it could be merged soon. @zmwangx As a alumnus of NSFZ 2012, 久仰大名😄 |
@zmwangx there are build failures for gifski, mgba, opencv@2, openimageio, and qcli. |
gifski reported here meh/rust-ffmpeg#112 and here ImageOptim/gifski#38 |
mgba is already fixed, so we can update it #26914 |
opencv was fixed in opencv/opencv#10011 but it was not backported to opencv@2 (the 2.4 branch). I've commented here: opencv/opencv#10011 (comment) |
openimageio reported here AcademySoftwareFoundation/OpenImageIO#1923 |
qcli was fixed in HEAD (bavc/qctools@e83d7ad) but there's no release with the fix yet. I've requested a release in bavc/qctools#538. |
bbf097f
to
1b4d410
Compare
Expecting qcli to be the sole failure, which isn't sufficient reason to block this upgrade or to add a versioned ffmpeg@3 formula. |
also serves as revision for ffmpeg
patch for FFmpeg 4.0 compatibility
fix for FFmpeg 4.0 compatibility
also bumping mpv to 0.28.2 as long as we're here |
@BrewTestBot test this please |
Sorry I didn't notice this before it got merged (need to add this to my email filters). I have compilation errors in some formulae in a 3rd-party tap. If there was an |
Created with
brew bump-formula-pr
.