Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAIDA's IXP info and membership #113

Merged

Conversation

romain-fontugne
Copy link
Member

@romain-fontugne romain-fontugne commented Jan 17, 2024

This adds CAIDA IXP information and IXP membership. It may adds some redundant links with PeeringDB but as it also adds new IXPs (found via HE) I wanted to make sure the links are consistent across all IXP.

How Has This Been Tested?

Tried locally, the data seems properly imported to me.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ x] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Member

@m-appel m-appel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some comment :)
We should also update the README since there are dependencies. The ix_asns crawler depends on ixs, and ixs depends on the PeeringDB crawlers.

iyp/crawlers/caida/ix-asns.py Outdated Show resolved Hide resolved
iyp/crawlers/caida/ix-asns.py Outdated Show resolved Hide resolved
iyp/crawlers/caida/ixs.py Show resolved Hide resolved
iyp/crawlers/caida/ixs.py Outdated Show resolved Hide resolved
iyp/crawlers/caida/ixs.py Show resolved Hide resolved
iyp/crawlers/caida/ix-asns.py Outdated Show resolved Hide resolved
iyp/crawlers/caida/ixs.py Show resolved Hide resolved
@m-appel m-appel linked an issue Jan 19, 2024 that may be closed by this pull request
@romain-fontugne
Copy link
Member Author

Thanks for the comments. I have completely forgot about the README! 😨

Copy link
Member

@m-appel m-appel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me now.

@m-appel m-appel merged commit 9cf01c5 into InternetHealthReport:main Jan 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CAIDA's IXP data
2 participants