feat!: upgrade bmuschko docker plugin (#93001) #93
Conversation
skiesewetter-intershop
commented
Feb 6, 2024
skiesewetter-intershop
commented
- gradle tasks to start a container have been split into the 3 different aspects:
- find the container by name
- if not existing: create
- if not running: start
* gradle tasks to start a container have been split into the 3 different aspects: 1. *find* the container by name 2. if not existing: *create* 3. if not running: *start*
skiesewetter-intershop
requested review from
DevDavido,
Thomas-Bergmann,
stefanh1,
m-raab,
SteBoe82 and
cortlepp
skiesewetter-intershop
had a problem deploying
to
CIRelease
GitHub Actions
Failure
Test Results19 tests - 4 17 ✅ - 4 1m 51s ⏱️ -7s Results for commit ae773fd. ± Comparison against base commit f42224d. This pull request removes 4 tests.♻️ This comment has been updated with latest results. |
* rolled back unnecessary update of icm-gradle-plugin:6.0.0 to 6.0.1
skiesewetter-intershop
temporarily deployed
to
CIRelease
GitHub Actions
Inactive
skiesewetter-intershop
temporarily deployed
to
CIRelease
GitHub Actions
Inactive
| @@ -210,7 +209,6 @@ imageBuild { | |||
| |`webadapter` | `Property<String>` | `docker.intershop.de/intershop/icm-webadapter:latest` | The image contains the web server of the Intershop Commerce Management application with a special Intershop Apache module. | |||
| |`webadapteragent` | `Property<String>` | `docker.intershop.de/intershop/icm-webadapteragent:latest` | The web adapter agent image of the Intershop Commerce Management application. | |||
| |`mssqldb` | `Property<String>` | `mcr.microsoft.com/mssql/server:2019-latest` | The Microsoft SQL server image. There will be also a build file available. | |||
There was a problem hiding this comment.
I know you didn't touch this, but the mssql image is incorrect and the solr one should also be solr:latest. But now that I look at it most of the images are actually wrong, since they are now all hosted on dockerhub. So maybe we should fix all of them in a separate PR.
There was a problem hiding this comment.
Yes, maybe we should fix this inside a separate PR.
skiesewetter-intershop
deleted the
93001-upgrade-bmuschko-docker-plugin
branch
| regAuthLocator = RegistryAuthLocator(configFile) | ||
| project.logger.info("This docker configuration is used: '{}'", configFile.absolutePath) | ||
| } | ||
| // if (project.findProperty("icm.docker.config") != null) { |
There was a problem hiding this comment.
Please delete this, or if there is a good reason why it must stay commented out, comment that in the code.
| task.existingContainer.set(project.provider { findTask.get().foundContainer.orNull }) | ||
| task.containerName.set(getContainerName()) | ||
|
|
||
| val os: OperatingSystem = DefaultNativePlatform.getCurrentOperatingSystem() |
There was a problem hiding this comment.
I think it would be better to rely on the system property System.properties['os.name'] for this. Because DefaultNativePlatform is internal, it may break with any minor gradle release.
| ) | ||
| } | ||
|
|
||
| /* FIXME SKR project.tasks.register("start${this.getExtensionName()}", StartServerContainer::class.java) { task -> |
There was a problem hiding this comment.
Why is this commented out?
