Fix symlinks in the build script. #61
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issam-b
reviewed
Aug 11, 2024
There was a problem hiding this comment.
Thanks @carlonluca, could you expand the commit message on this is doing to fix the symlinks?
These symlinks were created by the script before this patch: root@4923c457fa27:~/android_openssl/ssl_3/arm64-v8a# tree . ├── include -> ../ssl_3/include ├── libcrypto.a ├── libcrypto.so -> ../ssl_3/arm64-v8a/libcrypto_3.so ├── libcrypto_3.so ├── libssl.a ├── libssl.so -> ../ssl_3/arm64-v8a/libssl_3.so └── libssl_3.so After the fix, this is the result: root@4923c457fa27:~/android_openssl/ssl_3/arm64-v8a# tree . ├── include -> ../../ssl_3/include ├── libcrypto.a ├── libcrypto.so -> libcrypto_3.so ├── libcrypto_3.so ├── libssl.a ├── libssl.so -> libssl_3.so └── libssl_3.so
|
I updated the commit message with more details. |
Issam-b
added a commit
to Issam-b/android_openssl
that referenced
this pull request
Sep 15, 2024
* The script now supports zsh and bash to allow building from macOS and Linux with builtin zsh and bash version 3 or 4. * It now uses curl instead of wget, wget is not builtin on macOS. * Use the default NDk path from the Android SDK. * Allow to set custom build and output folders. * The various build folders for each version are now kept around under the 'build' folder. * At the same time add the build folder to .gitignore. * Create relative symlinks KDAB#61.
Issam-b
added a commit
to Issam-b/android_openssl
that referenced
this pull request
Sep 15, 2024
* The script now supports zsh and bash to allow building from macOS and Linux with builtin zsh and bash version 3 or 4. * It now uses curl instead of wget, wget is not builtin on macOS. * Use the default NDk path from the Android SDK. * Allow to set custom build and output folders. * The various build folders for each version are now kept around under the 'build' folder. * At the same time add the build folder to .gitignore. * Create relative symlinks KDAB#61.
Issam-b
added a commit
to Issam-b/android_openssl
that referenced
this pull request
Sep 16, 2024
* The script now supports zsh and bash to allow building from macOS and Linux with builtin zsh and bash version 3 or 4. * It now uses curl instead of wget, wget is not builtin on macOS. * Use the default NDk path from the Android SDK. * Allow to set custom build and output folders. * The various build folders for each version are now kept around under the 'build' folder. * At the same time add the build folder to .gitignore. * Create relative symlinks KDAB#61.
Issam-b
added a commit
to Issam-b/android_openssl
that referenced
this pull request
Sep 16, 2024
* The script now supports zsh and bash to allow building from macOS and Linux with builtin zsh and bash version 3 or 4. * It now uses curl instead of wget, wget is not builtin on macOS. * Use the default NDk path from the Android SDK. * Allow to set custom build and output folders. * The various build folders for each version are now kept around under the 'build' folder. * At the same time add the build folder to .gitignore. * Create relative symlinks KDAB#61.
Issam-b
added a commit
to Issam-b/android_openssl
that referenced
this pull request
Sep 20, 2024
* The script now supports zsh and bash to allow building from macOS and Linux with builtin zsh and bash version 3 or 4. * It now uses curl instead of wget, wget is not builtin on macOS. * Use the default NDk path from the Android SDK. * Allow to set custom build and output folders. * The various build folders for each version are now kept around under the 'build' folder. * At the same time add the build folder to .gitignore. * Create relative symlinks KDAB#61.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current script did not create the proper symlinks for me. This is how I fixed it.