-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MacOS support #62
MacOS support #62
Conversation
probably okay to address code-signing later? |
i actually havent tested the CI's output builds yet, i'll do that rn, then mark as ready for review if they do work, but yeah we can manage code signing at another time |
The builds do not work and i do not know why, i'll take a look later |
If any help is needed here, I'd be willing to provide. I'm a seasoned macOS developer who's currently taken interest in this project (and just recently set up a private Refresh server for my Discord server.) I have also used the latest build to patch LBP3 and LBP2 on my PS3 over LAN - it worked just fine*. My config is a MacBook Pro (16-inch, 2021) with M1 Pro. *Required me to |
It seems that the Info.plist needs to be in the root of the Mac project - that means it will need to be in the same folder as Refresher.csproj. However, this does mean full control over the Info.plist now!
They will be re-added by the compiler
And now, I eep
Signed-off-by: Eva Isabella Luna <[email protected]>
Closes #32 |
* Add macOS release support, and fix exectuable bits on Linux * Switch to a new action This might give control over the body? * Not latest, v1.14.0 * Add RELEASE_NOTES.md This works around an issue with the action where markdown isn't parsed correctly. Also changed the artifact names globally to make things nicer on the eyes and more consistent. * ...what * Fix formatting * Switch to the good ol' syntax * Should find the file now? * Fix 1
Co-authored-by: Beyley Thomas <[email protected]> Signed-off-by: Eva Isabella Luna <[email protected]>
After PR #66, I can't think of anything else that's required to merge in this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't really give this a proper review, but here's what I can spot at a glance.
* Use tarballs for releases instead of zips No double acrhive since this isn't a workflow * Whoops, need to change filenames * Skill issue * bre * will this work? * what is the issue? * this should work * bruh * bruh x2 * bruh x3 * bruh x4 * bruh x5 * bruh x6 * Attempt 1 for universal2 builds * Now bring this to the releases...
Signed-off-by: Eva Isabella Luna <[email protected]>
Signed-off-by: Eva Isabella Luna <[email protected]>
Closes #32
no code signing yet, still need to handle that