Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS support #62

Merged
merged 34 commits into from
Jun 4, 2024
Merged

MacOS support #62

merged 34 commits into from
Jun 4, 2024

Conversation

Beyley
Copy link
Member

@Beyley Beyley commented May 3, 2024

Closes #32

no code signing yet, still need to handle that

@jvyden
Copy link
Member

jvyden commented May 7, 2024

probably okay to address code-signing later?

@Beyley
Copy link
Member Author

Beyley commented May 7, 2024

i actually havent tested the CI's output builds yet, i'll do that rn, then mark as ready for review if they do work, but yeah we can manage code signing at another time

@Beyley
Copy link
Member Author

Beyley commented May 7, 2024

The builds do not work and i do not know why, i'll take a look later

@crystall1nedev
Copy link
Contributor

crystall1nedev commented May 8, 2024

If any help is needed here, I'd be willing to provide. I'm a seasoned macOS developer who's currently taken interest in this project (and just recently set up a private Refresh server for my Discord server.)

I have also used the latest build to patch LBP3 and LBP2 on my PS3 over LAN - it worked just fine*. My config is a MacBook Pro (16-inch, 2021) with M1 Pro.

*Required me to chmod +x the executable inside of the app bundle and xattr -cr the app itself.

@speedyman08
Copy link

Closes #32

* Add macOS release support, and fix exectuable bits on Linux

* Switch to a new action

This might give control over the body?

* Not latest, v1.14.0

* Add RELEASE_NOTES.md

This works around an issue with the action where markdown isn't parsed correctly.

Also changed the artifact names globally to make things nicer on the eyes and more consistent.

* ...what

* Fix formatting

* Switch to the good ol' syntax

* Should find the file now?

* Fix 1
@crystall1nedev
Copy link
Contributor

After PR #66, I can't think of anything else that's required to merge in this one.

@Beyley Beyley marked this pull request as ready for review May 27, 2024 04:46
@Beyley Beyley requested a review from jvyden May 27, 2024 04:46
Copy link
Member

@jvyden jvyden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't really give this a proper review, but here's what I can spot at a glance.

.github/workflows/dotnet.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
RELEASE_NOTES.md Show resolved Hide resolved
* Use tarballs for releases instead of zips

No double acrhive since this isn't a workflow

* Whoops, need to change filenames

* Skill issue

* bre

* will this work?

* what is the issue?

* this should work

* bruh

* bruh x2

* bruh x3

* bruh x4

* bruh x5

* bruh x6

* Attempt 1 for universal2 builds

* Now bring this to the releases...
@Beyley Beyley requested a review from jvyden June 4, 2024 20:15
@Beyley Beyley merged commit 08102da into main Jun 4, 2024
6 checks passed
@Beyley Beyley deleted the osx branch June 4, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mac OS Support
4 participants