Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

Add the appliance_console menu tree model. #8137

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add the appliance_console menu tree model. #8137

wants to merge 6 commits into from

Conversation

jarovo
Copy link
Contributor

@jarovo jarovo commented Nov 13, 2018

Purpose or Intent

There were some changes introduced to 5.10 which made the console tree different from 5.9. This breaks many tests. I am adding modeling of the console tree in the code so there is an additional layer to lessen the coupling of the menu options to the flow of the actual test.

This also in turn makes the tests more readable and self-documenting.

@dajoRH
Copy link
Contributor

dajoRH commented Jan 17, 2019

Lint report for commit 228bdb8:

cfme/utils/appliance/__init__.py:

  • 🔴 Line 6:1: F401 'tempfile' imported but unused
  • 🔴 Line 17:1: F401 'lxml.etree' imported but unused

cfme/utils/appliance/appliance_console.py:

  • ‼️ Line 67:5: E303 too many blank lines (2)
  • 🔴 Line 210:36: F821 undefined name 'six'
  • 🔴 Line 224:20: F821 undefined name 'socket'
  • 🔴 Line 240:14: F821 undefined name 'tempfile'
  • 🔴 Line 241:21: F821 undefined name 'hidden'
  • 🔴 Line 243:13: F821 undefined name 'os'
  • 🔴 Line 258:19: F821 undefined name 'yaml'
  • 🔴 Line 261:16: F821 undefined name 'lxml'

Hmmm
😱 You might like to check the lint of your code ☝️

No commit flaws detected.

CFME QE Bot

@dajoRH
Copy link
Contributor

dajoRH commented Jan 17, 2019

Would you mind rebasing this Pull Request against latest master, please? :trollface:
CFME QE Bot

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants