Use core minimum but allow 7.0/7.1/7.2 since core sets upper limit #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 tasks
Fryguy
reviewed
Sep 25, 2024
manageiq-api-client.gemspec
Outdated
| @@ -6,6 +6,7 @@ require 'manageiq/api/client/version' | |||
| Gem::Specification.new do |spec| | |||
| spec.name = "manageiq-api-client" | |||
| spec.version = ManageIQ::API::Client::VERSION | |||
| spec.required_ruby_version = '>= 3.0' | |||
There was a problem hiding this comment.
This is a weird spot within the file to put this. I think typically this line comes before the dependencies list in it's own paragraph, so let's move it down this.
There was a problem hiding this comment.
haha, I was following the convention we had in a few where it followed the version, like above. I agree. I can move it.
There was a problem hiding this comment.
oh weird - we should change those other ones then, too
Drop end of life rubies and rails and add new versions Ensure we're testing and supporting community supported versions. Drop: * rails 6.0 * rails 6.1 Add: * ruby 3.2 * ruby 3.3 * rails 7.1 * rails 7.2 Note: ruby 3.0 is not difficult to keep maintaining for now but it's on the chopping block.
jrafanie
force-pushed
the
update_ruby_rails_dependencies
branch
from
5396c94 to
3a2ff38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop end of life rubies and rails and add new versions
Ensure we're testing and supporting community supported versions.
Drop:
Add:
Note: ruby 3.0 is not difficult to keep maintaining for now but it's on the chopping block.