Main

fix: throw explicit error when `KeyringController` is locked #14635

Triggered via pull request January 17, 2025 13:45

mikesposito

synchronize #5172

fix/assert-controller-unlocked

Status Success

Total duration 4m 20s

Artifacts –

main.yml

on: pull_request

Check workflows

Matrix: Lint, build, and test / Prepare

Matrix: Lint, build, and test / Build

Matrix: Lint, build, and test / Lint

Matrix: Lint, build, and test / Test

Matrix: Lint, build, and test / Validate changelog

Determine whether this is a release merge commit

All jobs complete

Publish release / publish-release

All jobs pass

Publish release / publish-npm-dry-run

Publish release / publish-npm

Create update issues / create-update-issues

Annotations

119 warnings

Check workflows

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Prepare (20.x)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Prepare (18.x)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Validate changelog (20.x, @metamask/logging-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Validate changelog (20.x, @metamask/accounts-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Validate changelog (20.x, @metamask/permission-log-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Validate changelog (20.x, @metamask/multichain)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Validate changelog (20.x, @metamask/name-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Validate changelog (20.x, @metamask/notification-services-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Validate changelog (20.x, @metamask/keyring-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Validate changelog (20.x, @metamask/remote-feature-flag-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Validate changelog (20.x, @metamask/phishing-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Validate changelog (20.x, @metamask/permission-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Validate changelog (20.x, @metamask/queued-request-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Validate changelog (20.x, @metamask/rate-limit-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Validate changelog (20.x, @metamask/controller-utils)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Validate changelog (20.x, @metamask/signature-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Validate changelog (20.x, @metamask/user-operation-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Validate changelog (20.x, @metamask/announcement-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Validate changelog (20.x, @metamask/eth-json-rpc-provider)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Validate changelog (20.x, @metamask/composable-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Validate changelog (20.x, @metamask/json-rpc-middleware-stream)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Validate changelog (20.x, @metamask/address-book-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Validate changelog (20.x, @metamask/ens-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Validate changelog (20.x, @metamask/gas-fee-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Validate changelog (20.x, @metamask/approval-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Validate changelog (20.x, @metamask/polling-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Validate changelog (20.x, @metamask/assets-controllers)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Validate changelog (20.x, @metamask/selected-network-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Validate changelog (20.x, @metamask/profile-sync-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Validate changelog (20.x, @metamask/network-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Validate changelog (20.x, @metamask/json-rpc-engine)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Validate changelog (20.x, @metamask/preferences-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Validate changelog (20.x, @metamask/message-manager)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Validate changelog (20.x, @metamask/transaction-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (18.x, @metamask/announcement-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (18.x, @metamask/approval-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (18.x, @metamask/json-rpc-middleware-stream)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Validate changelog (20.x, @metamask/build-utils)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (20.x, @metamask/address-book-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (20.x, @metamask/build-utils)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (20.x, @metamask/json-rpc-middleware-stream)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (18.x, @metamask/composable-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (18.x, @metamask/eth-json-rpc-provider)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (18.x, @metamask/permission-log-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (20.x, @metamask/ens-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (20.x, @metamask/approval-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (18.x, @metamask/accounts-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (20.x, @metamask/announcement-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (18.x, @metamask/json-rpc-engine)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (18.x, @metamask/gas-fee-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (20.x, @metamask/permission-log-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (18.x, @metamask/base-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (18.x, @metamask/preferences-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (18.x, @metamask/address-book-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Validate changelog (20.x, @metamask/base-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (20.x, @metamask/accounts-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (18.x, @metamask/logging-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (20.x, @metamask/selected-network-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (18.x, @metamask/build-utils)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (18.x, @metamask/controller-utils)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (18.x, @metamask/phishing-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (20.x, @metamask/logging-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (18.x, @metamask/rate-limit-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (20.x, @metamask/rate-limit-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (20.x, @metamask/preferences-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (18.x, @metamask/message-manager)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (18.x, @metamask/ens-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (18.x, @metamask/selected-network-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (20.x, @metamask/polling-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (18.x, @metamask/multichain)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (20.x, @metamask/controller-utils)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (18.x, @metamask/queued-request-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (20.x, @metamask/phishing-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (20.x, @metamask/gas-fee-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (18.x, @metamask/permission-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (18.x, @metamask/polling-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (20.x, @metamask/composable-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (18.x, @metamask/name-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (20.x, @metamask/multichain)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (20.x, @metamask/eth-json-rpc-provider)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (20.x, @metamask/signature-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (18.x, @metamask/signature-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (20.x, @metamask/permission-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (20.x, @metamask/json-rpc-engine)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (20.x, @metamask/base-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (20.x, @metamask/name-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (18.x, @metamask/keyring-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (20.x, @metamask/message-manager)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (20.x, @metamask/keyring-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (20.x, @metamask/queued-request-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (20.x, @metamask/user-operation-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (18.x, @metamask/remote-feature-flag-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (18.x, @metamask/user-operation-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (20.x, @metamask/remote-feature-flag-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (18.x, @metamask/notification-services-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (20.x, @metamask/notification-services-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (20.x, @metamask/transaction-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (18.x, @metamask/profile-sync-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (20.x, @metamask/profile-sync-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (18.x, @metamask/transaction-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (20.x, @metamask/assets-controllers)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (18.x, @metamask/assets-controllers)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Test (18.x, @metamask/network-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Lint (20.x)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Lint (20.x): examples/example-controllers/src/gas-prices-controller.test.ts#L5

`../../../packages/base-controller/tests/helpers` type import should occur after import of `./network-controller-types`

Lint, build, and test / Lint (20.x): examples/example-controllers/src/gas-prices-controller.ts#L196

Member '#gasPricesService' is never reassigned; mark it as `readonly`

Lint, build, and test / Lint (20.x): examples/example-controllers/src/gas-prices-controller.ts#L241

Replace `·await·this.#gasPricesService.fetchGasPrices(⏎······chainId,⏎····` with `⏎······await·this.#gasPricesService.fetchGasPrices(chainId`

Lint, build, and test / Lint (20.x): examples/example-controllers/src/gas-prices-service/gas-prices-service.ts#L41

Member '#fetch' is never reassigned; mark it as `readonly`

Lint, build, and test / Lint (20.x): examples/example-controllers/src/gas-prices-service/gas-prices-service.ts#L56

Missing JSDoc @returns declaration

Lint, build, and test / Lint (20.x): examples/example-controllers/src/pet-names-controller.test.ts#L8

`./pet-names-controller` type import should occur before type import of `../../../packages/base-controller/tests/helpers`

Lint, build, and test / Lint (20.x): examples/example-controllers/src/pet-names-controller.test.ts#L9

`./pet-names-controller` import should occur before type import of `../../../packages/base-controller/tests/helpers`

Lint, build, and test / Lint (20.x): packages/accounts-controller/src/AccountsController.test.ts#L18

No exported names found in module 'uuid'

Lint, build, and test / Lint (20.x): packages/accounts-controller/src/AccountsController.test.ts#L137

Member '#accountIds' is never reassigned; mark it as `readonly`

Lint, build, and test / Lint (20.x): packages/accounts-controller/src/AccountsController.ts#L388

Expected 1 lines after block description

Lint, build, and test / Test (20.x, @metamask/network-controller)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Lint, build, and test / Build (20.x)

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

All jobs complete

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

All jobs pass

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: throw explicit error when `KeyringController` is locked #14635

Summary