-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: When attempting to send an ERC-721 token, users encounter an issue where the "Next" button is disabled, preventing the transaction from proceeding. Furthermore, this issue persists into subsequent attempts to send ERC-20 tokens, with the "Next" button remaining disabled on the Confirmation screen #12317
Comments
Same behavior on Android: nftAndroid.mov |
Sending NFT works, but message with 'Fiat conversions are not available at this moment' is displayed when attempting to send any token and MetaMask app closes
I obtained the build from here Sending.NFT.mov |
In RC v7.36.0 (1501) from here Before sending the ERC721 token:
Sending.ERC721.token.movAfter sending the ERC721 token:
After.sending.ERC721.token.mov |
Disabled 'Next' button bug is present in 7.37.0 (1506): RPReplay_Final1732861827.MP4 |
Also present in 7.37.0 (1508) - Android Send.ERC721.-.disabled.next.button.mov |
Present in the latest main, Bitrise build. Currently, a user's interaction with ERC-721 tokens is limited to merely opening the NFT tab. Subsequently, this action renders the option to send any token on Ethereum unavailable: nft.mov |
Present in the RC 7.38.0(1521): 1.mp4 |
In v7.38.0 (1523) the Next button is enabled, but unable to send ERC721 due to the following errors:
When trying to raise the gas limit and the gas fee, the transactions are failing Sending.NFT.error.mov |
In v7.38.0 (1524) the Next button is enabled, but unable to send ERC721 due to the following errors:
Send.NFT.error.mov |
For iOS, v7.38.0 (1524):
"Fiat conversions are not available" message and balance undefined - "Next" button disabled when attempting to send ERC20 token Send.NFT.iOS.movFiat.conversions.are.not.available.mov |
I’ve investigated this issue but haven’t made significant progress yet. It appears to involve two distinct problems:
I agree with the Sev1 classification; however, I’m not sure this should block the 7.38 release as it is not technically a regression from the previous release, and has been present in production since at least version 7.34. I have a very naive fix for the first issue (which I don’t believe is suitable for merging) but haven’t made substantial progress on the second. I don't have a ton of context regarding the send flow, which has been a challenge. From what I’ve observed, the root cause seems to be that Was there a recent change in how gas is calculated for sends in the TransactionsController? Could this be related to the I noticed that we are now passing a |
On v7.39.0 (1529) iOS:
iOS.v7.39.0.Send.NFT.mov |
On v7.39.0 (1529) Android:
Android.v7.39.0.Send.NFT.mov |
Describe the bug
When attempting to send an ERC-721 token, users encounter an issue where the "Next" button is disabled, preventing the transaction from proceeding. Furthermore, this issue persists into subsequent attempts to send ERC-20 tokens, with the "Next" button remaining disabled on the Confirmation screen and 'Fiat conversions are not available at this moment' message shown.
Additionally on the assets picker while on NFT tab only ERC 20 tokens displayed.
Seems like it first appeared in 7.43.0, also present in 7.36.0
Related: #12972
Expected behavior
Screenshots/Recordings
Sending ERC 721 works as expected in 7.33.2:
7_33_2.mov
Bug in 7.34.0:
7_34_0.mov
Bug in 7.36.0:
7_36_0.mov
Steps to reproduce
Error messages or log output
No response
Detection stage
In production (default)
Version
7.34.0 (1462)
Build type
None
Device
iPhone 15
Operating system
iOS
Additional context
No response
Severity
No response
The text was updated successfully, but these errors were encountered: