Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ramp): offramp welcome screen copy updates #7576

Merged
merged 7 commits into from
Nov 10, 2023
Merged

feat(ramp): offramp welcome screen copy updates #7576

merged 7 commits into from
Nov 10, 2023

Conversation

georgeweiler
Copy link
Contributor

@georgeweiler georgeweiler commented Oct 23, 2023 •
edited
Loading

Description

The welcome page for sell has different copy requirements. This PR updates copy based on rampType

Related issues

N/A

Manual testing steps

Check the sell version of the welcome page and verify that the copy has been updated

Screenshots/Recordings

Before

Screenshot 2023-11-08 at 11 19 45 AM

After

Screenshot 2023-11-08 at 11 18 47 AM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@georgeweiler georgeweiler requested a review from a team as a code owner October 23, 2023 18:04
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@wachunei
Copy link
Member

I will convert this into draft until tests are done

@wachunei wachunei marked this pull request as draft October 24, 2023 20:07
@wachunei wachunei added the team-ramp issues related to Ramp features label Oct 24, 2023
@wachunei wachunei mentioned this pull request Nov 8, 2023
Merged
13 tasks
@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-ramp-qa Tickets that need feature QA on the ramps flows labels Nov 8, 2023
@georgeweiler georgeweiler changed the title Feat/offramp welcome screen feat(ramp): offramp welcome screen copy updates Nov 8, 2023
@metamaskbot metamaskbot added INVALID-PR-TEMPLATE PR's body doesn't match template and removed INVALID-PR-TEMPLATE PR's body doesn't match template labels Nov 8, 2023
@georgeweiler georgeweiler force-pushed the feat/offramp-welcome-screen branch from db29d5b to 0ba68cb Compare November 8, 2023 18:44
@georgeweiler georgeweiler marked this pull request as ready for review November 8, 2023 19:27
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/07464afe-526a-4ef7-9161-22a3733ab016
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

wachunei
wachunei approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@wachunei wachunei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 8, 2023
@georgeweiler georgeweiler force-pushed the feat/offramp-welcome-screen branch from 5c4567d to 32ae6ee Compare November 8, 2023 19:34
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fa6cb0a) 36.68% compared to head (44cb2b9) 36.69%.

Additional details and impacted files 
@@              Coverage Diff               @@
##           feat/off-ramp    #7576   +/-   ##
==============================================
  Coverage          36.68%   36.69%           
==============================================
  Files               1047     1047           
  Lines              27847    27849    +2     
  Branches            2416     2418    +2     
==============================================
+ Hits               10217    10219    +2     
  Misses             17058    17058           
  Partials             572      572
Files Coverage Δ
...onents/UI/Ramp/buy/Views/GetStarted/GetStarted.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Cal-L
Cal-L reviewed Nov 9, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one comment

locales/languages/en.json Show resolved Hide resolved
Cal-L
Cal-L approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wachunei wachunei force-pushed the feat/offramp-welcome-screen branch from cd22392 to e69eee4 Compare November 10, 2023 16:36
@bkirb
Copy link
Contributor

bkirb commented Nov 10, 2023

@georgeweiler LGTM I verified this change ✅

@wachunei wachunei added ramp-qa-passed and removed needs-ramp-qa Tickets that need feature QA on the ramps flows labels Nov 10, 2023
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@wachunei wachunei merged commit e1b7601 into feat/off-ramp Nov 10, 2023
25 checks passed
@wachunei wachunei deleted the feat/offramp-welcome-screen branch November 10, 2023 20:40
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

@wachunei wachunei wachunei approved these changes

Assignees
No one assigned
Labels
ramp-qa-passed team-ramp issues related to Ramp features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@georgeweiler @wachunei @codecov-commenter @bkirb @Cal-L @metamaskbot