Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ramp): offramp unsupported region copy update #7577

Merged
merged 7 commits into from
Nov 10, 2023
Merged

feat(ramp): offramp unsupported region copy update #7577

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
dc212cd
feat (ramp): update the Regions View to display the message of an uns…
georgeweiler Oct 23, 2023
362a833
chore(ramp): removes RegionModal dependency on RampSDK
georgeweiler Nov 8, 2023
55426b3
test(ramp): adds snapshot for unsupported sell region
georgeweiler Nov 8, 2023
f0c78db
feat(ramp): updates title copy for sell region page
georgeweiler Nov 8, 2023
cdea645
fix(ramp): updates regions dependency array to include missed isBuy v…
georgeweiler Nov 9, 2023
81ea49e
Merge branch 'feat/off-ramp' into feat/offramp-region-copy-update
wachunei Nov 10, 2023
353ca63
Merge branch 'feat/off-ramp' into feat/offramp-region-copy-update
wachunei Nov 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion app/components/UI/Ramp/buy/Views/Regions/Regions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,16 @@ const RegionsView = () => {
subtitle={`${unsupportedRegion?.emoji} ${unsupportedRegion?.name}`}
dismiss={clearUnsupportedRegion}
title={strings('fiat_on_ramp_aggregator.region.unsupported')}
body={strings('fiat_on_ramp_aggregator.region.unsupported_description')}
body={strings(
'fiat_on_ramp_aggregator.region.unsupported_description',
{
rampType: strings(
isBuy
? 'fiat_on_ramp_aggregator.buy'
: 'fiat_on_ramp_aggregator.sell',
),
},
)}
link={strings('fiat_on_ramp_aggregator.region.unsupported_link')}
/>

Expand Down
8 changes: 8 additions & 0 deletions app/components/UI/Ramp/common/components/RegionModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ const RegionModal: React.FC<Props> = ({
const list = useRef<FlatList<Region>>(null);
const [searchString, setSearchString] = useState('');
const [currentData, setCurrentData] = useState(data || []);
const isBuy = rampType === RampType.BUY;

// local state variable to set the active view (countries vs. regions)
const [activeView, setActiveView] = useState(RegionViewType.COUNTRY);
Expand Down Expand Up @@ -382,6 +383,13 @@ const RegionModal: React.FC<Props> = ({
title={strings('fiat_on_ramp_aggregator.region.unsupported')}
body={strings(
'fiat_on_ramp_aggregator.region.unsupported_description',
{
rampType: strings(
isBuy
? 'fiat_on_ramp_aggregator.buy'
: 'fiat_on_ramp_aggregator.sell',
),
},
)}
link={strings('fiat_on_ramp_aggregator.region.unsupported_link')}
/>
Expand Down
2 changes: 1 addition & 1 deletion locales/languages/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1987,7 +1987,7 @@
"select_region_title": "Select your Region",
"select_country_registered": "Select the country where your card is registered (regardless of where you are located).",
"unsupported": "Region Not Supported",
"unsupported_description": "We are working hard to expand coverage to your region as soon as we can. In the meantime, see our support article for other ways you may be able to buy crypto.",
"unsupported_description": "We are working hard to expand coverage to your region as soon as we can. In the meantime, see our support article for other ways you may be able to {{rampType}} crypto.",
"unsupported_link": "Visit Support Article"
},
"order_details": {
Expand Down