-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ramp): offramp unsupported region copy update #7577
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
I will turn into draft until the tests are done |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/off-ramp #7577 +/- ##
==============================================
Coverage 36.69% 36.70%
==============================================
Files 1051 1051
Lines 27943 27947 +4
Branches 2440 2443 +3
==============================================
+ Hits 10254 10258 +4
Misses 17114 17114
Partials 575 575
☔ View full report in Codecov by Sentry. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0fe3df5e-aa7f-46b0-8a19-2425aef61fe2 |
…upported ramp type (eg: unsupported sell)
26b1819
to
dc212cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b2fbecb
to
cdea645
Compare
309966b
to
fa6cb0a
Compare
@georgeweiler LGTM I verified this change ✅ |
Kudos, SonarCloud Quality Gate passed! |
Description
Very small copy change to the ramp regions page to support new Sell copy requirements
Related issues
N/A
Manual testing steps
Check the sell version of the region page and verify that the copy has been updated
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist