Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ramp): offramp unsupported region copy update #7577

Merged
merged 7 commits into from
Nov 10, 2023

Conversation

georgeweiler
Copy link
Contributor

@georgeweiler georgeweiler commented Oct 23, 2023

Description

Very small copy change to the ramp regions page to support new Sell copy requirements

Related issues

N/A

Manual testing steps

Check the sell version of the region page and verify that the copy has been updated

Screenshots/Recordings

Before

After

Screenshot 2023-11-08 at 11 41 48 AM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@georgeweiler georgeweiler requested a review from a team as a code owner October 23, 2023 18:31
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@georgeweiler georgeweiler changed the base branch from main to feat/off-ramp October 23, 2023 18:31
@georgeweiler georgeweiler added the team-ramp issues related to Ramp features label Oct 24, 2023
@georgeweiler georgeweiler changed the title Feat/offramp region copy update feat(ramp): offramp region copy update Oct 24, 2023
@wachunei
Copy link
Member

I will turn into draft until the tests are done

@wachunei wachunei marked this pull request as draft October 24, 2023 20:05
@wachunei wachunei mentioned this pull request Nov 8, 2023
13 tasks
@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-ramp-qa Tickets that need feature QA on the ramps flows labels Nov 8, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3ce1f31) 36.69% compared to head (353ca63) 36.70%.

Additional details and impacted files
@@              Coverage Diff               @@
##           feat/off-ramp    #7577   +/-   ##
==============================================
  Coverage          36.69%   36.70%           
==============================================
  Files               1051     1051           
  Lines              27943    27947    +4     
  Branches            2440     2443    +3     
==============================================
+ Hits               10254    10258    +4     
  Misses             17114    17114           
  Partials             575      575           
Files Coverage Δ
...p/components/UI/Ramp/buy/Views/Regions/Regions.tsx 96.66% <100.00%> (+0.23%) ⬆️
...mponents/UI/Ramp/common/components/RegionModal.tsx 55.84% <100.00%> (+1.17%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@georgeweiler georgeweiler marked this pull request as ready for review November 8, 2023 19:30
Copy link
Contributor

github-actions bot commented Nov 8, 2023

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0fe3df5e-aa7f-46b0-8a19-2425aef61fe2
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@georgeweiler georgeweiler force-pushed the feat/offramp-region-copy-update branch from 26b1819 to dc212cd Compare November 8, 2023 19:37
@georgeweiler georgeweiler changed the title feat(ramp): offramp region copy update feat(ramp): offramp unsupported region copy update Nov 8, 2023
@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 8, 2023
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wachunei wachunei force-pushed the feat/offramp-region-copy-update branch from b2fbecb to cdea645 Compare November 10, 2023 16:36
@bkirb
Copy link
Contributor

bkirb commented Nov 10, 2023

@georgeweiler LGTM I verified this change ✅

@wachunei wachunei added ramp-qa-passed and removed needs-ramp-qa Tickets that need feature QA on the ramps flows labels Nov 10, 2023
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@wachunei wachunei merged commit db763e3 into feat/off-ramp Nov 10, 2023
25 checks passed
@wachunei wachunei deleted the feat/offramp-region-copy-update branch November 10, 2023 20:41
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ramp-qa-passed team-ramp issues related to Ramp features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants