17.0.0 #313
Closed
17.0.0 #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Mrtenz
reviewed
Mar 20, 2024
CHANGELOG.md
Outdated
|
|
||
| ### Removed | ||
|
|
||
| - **BREAKING:** Revert Remove deprecated properties, networkChanged event, and offline send() net_version support ([#312](https://github.com/MetaMask/providers/pull/312)) |
There was a problem hiding this comment.
Why is this a breaking change? We're adding these things back right?
There was a problem hiding this comment.
I'd put this as non-breaking under ### Added.
Suggested change
| - **BREAKING:** Revert Remove deprecated properties, networkChanged event, and offline send() net_version support ([#312](https://github.com/MetaMask/providers/pull/312)) | |
| - Restore deprecated properties, `networkChanged` event, and offline `send()` of `net_version` ([#312](https://github.com/MetaMask/providers/pull/312)) |
There was a problem hiding this comment.
good catch. This is indeed nonbreaking
There was a problem hiding this comment.
You may need to recreate the release with the proper version. This should be a minor version bump.
There was a problem hiding this comment.
Reopened as 16.1.0 https://github.com/MetaMask/providers/pull/316/files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the release candidate for version 17.0.0.