Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17.0.0 #313

Closed
wants to merge 4 commits into from
Closed

17.0.0 #313

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
50236d6
17.0.0
invalid-email-address Mar 19, 2024
5e623bd
update changelog
jiexi Mar 19, 2024
0bc415f
Update changelog
jiexi May 1, 2024
9410921
Merge branch 'main' into release/17.0.0
jiexi May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [17.0.0]

### Changed

- Bump MetaMask dependencies ([#310](https://github.com/MetaMask/providers/pull/310))
- Bump @metamask/safe-event-emitter from 3.0.0 to 3.1.1 ([#309](https://github.com/MetaMask/providers/pull/309))

### Removed

- **BREAKING:** Revert Remove deprecated properties, networkChanged event, and offline send() net_version support ([#312](https://github.com/MetaMask/providers/pull/312))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this a breaking change? We're adding these things back right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd put this as non-breaking under ### Added.

Suggested change
- **BREAKING:** Revert Remove deprecated properties, networkChanged event, and offline send() net_version support ([#312](https://github.com/MetaMask/providers/pull/312))
- Restore deprecated properties, `networkChanged` event, and offline `send()` of `net_version` ([#312](https://github.com/MetaMask/providers/pull/312))

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. This is indeed nonbreaking

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated here 0bc415f

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may need to recreate the release with the proper version. This should be a minor version bump.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reopened as 16.1.0 https://github.com/MetaMask/providers/pull/316/files


## [16.0.0]

### Removed
Expand Down Expand Up @@ -382,7 +393,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
added deprecation warnings for them ([#30](https://github.com/MetaMask/providers/pull/30))
- Un-deprecated `sendAsync` ([#29](https://github.com/MetaMask/providers/pull/29))

[Unreleased]: https://github.com/MetaMask/providers/compare/v16.0.0...HEAD
[Unreleased]: https://github.com/MetaMask/providers/compare/v17.0.0...HEAD
[17.0.0]: https://github.com/MetaMask/providers/compare/v16.0.0...v17.0.0
[16.0.0]: https://github.com/MetaMask/providers/compare/v15.0.0...v16.0.0
[15.0.0]: https://github.com/MetaMask/providers/compare/v14.0.2...v15.0.0
[14.0.2]: https://github.com/MetaMask/providers/compare/v14.0.1...v14.0.2
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@metamask/providers",
"version": "16.0.0",
"version": "17.0.0",
"description": "A JavaScript Ethereum provider that connects to the wallet over a stream",
"keywords": [
"MetaMask",
Expand Down
Loading