Implements a fix for donator tokens being unlimited #5098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hi poobs
| @@ -101,7 +101,8 @@ GLOBAL_LIST_INIT(patreon_etoken_values, list( | |||
| return FALSE | |||
|
|
|||
| var/month_number = text2num(time2text(world.time, "MM")) | |||
|
|
|||
| if(owner.prefs.token_month == 0) | |||
There was a problem hiding this comment.
currently this means people wont get a token for their first month as patreon
There was a problem hiding this comment.
Any ideas on fixes for first month patreons?
| @@ -101,7 +101,8 @@ GLOBAL_LIST_INIT(patreon_etoken_values, list( | |||
| return FALSE | |||
|
|
|||
| var/month_number = text2num(time2text(world.time, "MM")) | |||
|
|
|||
| if(owner.prefs.token_month == 0) | |||
| owner.prefs.token_month = month_number | |||
| if(owner.prefs.token_month != month_number) | |||
There was a problem hiding this comment.
Suggested change
| if(owner.prefs.token_month != month_number) | |
| else if(owner.prefs.token_month != month_number) |
This was referenced Jan 27, 2025
Open
|
??????? |
it's a temporary fix, donators were getting unlimited donor tokens because their token_month was being lost at some point during saving/etc & this was the only solution we found so far. Basically they need to get moved over to DB or something but I have no clue what I'm doing on that side of things |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi poobs
Hopefully should stop donators from getting a token back if token_month is lost somehow.
Changelog
🆑
fix: fixed donator tokens being buggy (hopefully)
/:cl: