Fixing some todos #5927
pnowosieAnnotations
10 errors and 1 warning
|
lint:
core/state.go#L585
585-649 lines are duplicate of `core/state.go:655-719` (dupl)
|
|
lint:
core/state.go#L655
655-719 lines are duplicate of `core/state.go:585-649` (dupl)
|
|
lint:
blockchain/snap_server_interface.go#L111
Error return value is not checked (errcheck)
|
|
lint:
blockchain/snap_server_interface.go#L159
Error return value is not checked (errcheck)
|
|
lint:
sync/snap_server.go#L97
Error return value is not checked (errcheck)
|
|
lint:
sync/snapsyncer_test.go#L280
Error return value of `http.ListenAndServe` is not checked (errcheck)
|
|
lint:
sync/snapsyncer.go#L744
Function 'runStorageRangeWorker' is too long (155 > 120) (funlen)
|
|
lint:
blockchain/blockchain.go#L831
commentedOutCode: may want to remove commented-out code (gocritic)
|
|
lint:
sync/snap_server.go#L302
importShadow: shadow of imported from 'github.com/NethermindEth/juno/core/trie' package 'trie' (gocritic)
|
|
lint:
sync/snapsyncer.go#L175
commentedOutCode: may want to remove commented-out code (gocritic)
|
|
lint
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions/[email protected], golangci/golangci-lint-action@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|