Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

figure for submission #151

Merged
merged 1 commit into from
Nov 30, 2023
Merged

figure for submission #151

merged 1 commit into from
Nov 30, 2023

Conversation

ccluri
Copy link
Collaborator

@ccluri ccluri commented Nov 29, 2023

No description provided.

@ccluri ccluri requested a review from m-kowalska November 29, 2023 14:12
Copy link
Collaborator

@m-kowalska m-kowalska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • figures/kCSD_properties/L_curve_simulation.py - changes are ok, but it throws error: NameError: name 'noise_lvl' is not defined. I think function make_plot_perf (line 23 from figure_LCandCVperformance.py) should be rewritten and take 'noise_lvl' as an argument to solve the issue;
    line 121: polish name is used

  • figures/kCSD_properties/figure_LC.py - it throws error: NameError: name 'df' is not defined. Uncomment lines 103 and 106 and change name from 'data_fig4_and_fig13_lc_noise25.0.npz' to 'data_fig4_and_fig13_LC_noise25.0.npz' in line 106;
    line 108: polish name is used

  • figures/kCSD_properties/figure_LCandCVperformance.py - it works, I accept changes, but I think function make_plot_perf (line 23) should be rewritten (see above)

@m-kowalska m-kowalska merged commit 6676bae into master Nov 30, 2023
4 checks passed
@ccluri ccluri deleted the figs2023 branch December 21, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants