-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
protobuf3_20: remove #334067
protobuf3_20: remove #334067
Conversation
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4526 |
88a2325
to
2cc1c9e
Compare
@ofborg eval |
Hello, is there any possibility to get this change reverted? I am in the process of packaging lark-oapi, which unfortunately depends on protobuf3, and it seems that it is unlikely that the project maintainers will migrate to a newer protobuf version (see larksuite/oapi-sdk-python#77; might want to translate the comments to your prefered language) |
@yoctocell I don't think there's any problem; you can try submitting a PR. |
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.