Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protobuf3_20: remove #334067

Merged
merged 2 commits into from
Oct 23, 2024
Merged

protobuf3_20: remove #334067

merged 2 commits into from
Oct 23, 2024

Conversation

aaronjheng
Copy link
Contributor

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Aug 12, 2024
@aaronjheng aaronjheng marked this pull request as ready for review August 12, 2024 07:08
@aaronjheng aaronjheng requested a review from natsukium as a code owner August 12, 2024 07:08
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4526

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 27, 2024
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 30, 2024
@Aleksanaa
Copy link
Member

@ofborg eval

@Aleksanaa Aleksanaa merged commit 65c7a01 into NixOS:master Oct 23, 2024
21 checks passed
@yoctocell
Copy link
Member

yoctocell commented Nov 9, 2024

Hello, is there any possibility to get this change reverted? I am in the process of packaging lark-oapi, which unfortunately depends on protobuf3, and it seems that it is unlikely that the project maintainers will migrate to a newer protobuf version (see larksuite/oapi-sdk-python#77; might want to translate the comments to your prefered language)

@aaronjheng aaronjheng deleted the protobuf branch November 10, 2024 10:47
@aaronjheng
Copy link
Contributor Author

@yoctocell I don't think there's any problem; you can try submitting a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants