Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #26207: Plugin management operations need confirmation popup and license error info #6134

Open
wants to merge 2 commits into
base: branches/rudder/8.3
Choose a base branch
from
Open

Fixes #26207: Plugin management operations need confirmation popup and license error info #6134

wants to merge 2 commits into from
+233 −86

Conversation

clarktsiory
Copy link
Contributor

@clarktsiory clarktsiory commented Jan 20, 2025 •
edited
Loading

https://issues.rudder.io/issues/26207

Adding modals to confirm actions on plugins :
image

Fixing also some other problems :

  • in case of missing license, the plugin is not supposed to be selected
  • disable and enable action were not working due to the command being "enabled/disabled" instead of "enable/disable"
  • sorting the plugins by their status, then by alphabetical order, using the elm-ordering lib which is very handy for that
  • minor SCSS adjustments

@clarktsiory
fixup! Fixes #26207: Plugin management operations need confirmation p…
a185c2b 
…opup and license error info

Fixes #26207: Plugin management operations need confirmation popup and license error info
@clarktsiory
Copy link
Contributor Author

PR updated with a new commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaphaelGauthier RaphaelGauthier RaphaelGauthier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clarktsiory @RaphaelGauthier