Fixes #26207: Plugin management operations need confirmation popup and license error info

webapp/sources/rudder/rudder-core/src/main/scala/com/normation/plugins/PluginSettings.scala

@@ -39,6 +39,8 @@ package com.normation.plugins
 
 import better.files.File
 import com.normation.errors.*
+import com.normation.plugins.PluginSystemStatus.Disabled
+import com.normation.plugins.PluginSystemStatus.Enabled
 import com.normation.plugins.RudderPackageService.*
 import com.normation.rudder.domain.logger.ApplicationLoggerPure
 import com.normation.rudder.hooks.Cmd
@@ -660,7 +662,11 @@ class RudderPackageCmdService(configCmdLine: String) extends RudderPackageServic
   }
 
   override def changePluginSystemStatus(status: PluginSystemStatus, plugins: Chunk[String]): IOResult[Unit] = {
-    runCmdOrFail(status.value :: plugins.toList)(
+    val action = status match {
+      case Enabled  => "enable"
+      case Disabled => "disable"
+    }
+    runCmdOrFail(action :: plugins.toList)(
       s"An error occurred while changin plugin status to ${status.value}"
     ).unit
   }

webapp/sources/rudder/rudder-web/src/main/elm/elm.json

@@ -36,6 +36,7 @@
             "justinmimbs/date": "4.1.0",
             "justinmimbs/time-extra": "1.2.0",
             "jzxhuang/http-extras": "2.1.0",
+            "matthewsj/elm-ordering": "2.0.0",
             "mcordova47/elm-natural-ordering": "1.1.0",
             "mercurymedia/elm-datetime-picker": "8.0.1",
             "pablen/toasty": "1.2.0",

webapp/sources/rudder/rudder-web/src/main/elm/sources/Plugins.elm

@@ -63,6 +63,9 @@ update msg model =
                 Err err ->
                     processApiErrorBytes "Error while fetching information" err model
 
+        SetModalState modalState ->
+            ( { model | ui = (\ui -> { ui | modalState = modalState }) model.ui }, Cmd.none )
+
         Copy s ->
             ( model, copy s )
 

webapp/sources/rudder/rudder-web/src/main/elm/sources/Plugins/ApiCalls.elm

@@ -62,3 +62,19 @@ changePluginStatus requestType plugins model =
         , timeout = Nothing
         , tracker = Nothing
         }
+
+
+requestTypeAction : RequestType -> Model -> Cmd Msg
+requestTypeAction t model =
+    case t of
+        Install ->
+            installPlugins model.ui.selected model
+
+        Uninstall ->
+            removePlugins model.ui.selected model
+
+        Enable ->
+            changePluginStatus Enable model.ui.selected model
+
+        Disable ->
+            changePluginStatus Disable model.ui.selected model

webapp/sources/rudder/rudder-web/src/main/elm/sources/Plugins/DataTypes.elm

@@ -5,6 +5,7 @@ import Http
 import Http.Detailed
 import Json.Encode exposing (Value)
 import List.Extra
+import Ordering exposing (Ordering)
 import Time.ZonedDateTime exposing (ZonedDateTime)
 
 
@@ -68,10 +69,16 @@ type alias PluginError =
 
 type alias UI =
     { selected : List PluginId
+    , modalState : ModalState
     , settingsError : Maybe ( String, String ) -- message, details
     }
 
 
+type ModalState
+    = OpenModal RequestType
+    | NoModal
+
+
 type alias Model =
     { contextPath : String
     , license : LicenseGlobalInfo
@@ -98,6 +105,7 @@ type Msg
     = CallApi (Model -> Cmd Msg)
     | ApiGetPlugins (Result (Http.Detailed.Error String) ( Http.Metadata, PluginsInfo ))
     | ApiPostPlugins (Result (Http.Detailed.Error Bytes) RequestType)
+    | SetModalState ModalState
     | Copy String
     | CopyJson Value
     | CheckSelection Select
@@ -171,3 +179,14 @@ noGlobalLicense =
     , endDate = Nothing
     , maxNodes = Nothing
     }
+
+
+pluginStatusOrdering : Ordering PluginStatus
+pluginStatusOrdering =
+    Ordering.explicit [ Enabled, Disabled, Uninstalled ]
+
+
+pluginDefaultOrdering : Ordering PluginInfo
+pluginDefaultOrdering =
+    Ordering.byFieldWith pluginStatusOrdering .status
+        |> Ordering.breakTiesWith (Ordering.byField .name)

webapp/sources/rudder/rudder-web/src/main/elm/sources/Plugins/Init.elm

@@ -13,7 +13,7 @@ init : { contextPath : String } -> ( Model, Cmd Msg )
 init flags =
     let
         initUI =
-            UI [] Nothing
+            UI [] NoModal Nothing
 
         initModel =
             Model flags.contextPath noGlobalLicense [] initUI