Add activation flow preference test #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablothedude
force-pushed
the
feature/add-activation-flow-preference-test
branch
2 times, most recently
from
2ae8392 to
9550754
Compare
MKodde
reviewed
Nov 6, 2024
There was a problem hiding this comment.
Awesome to cover these vetting nudging flows in the behat tests.
IRL you mentioned that the new feature to express the preference via a entitlement attribute was hard to test in this test suite right? OpenConext/Stepup-SelfService#336. It might be possible to collaborate with Pieter and create a new feature in the SSP SP.php test page. And let the SP notify the demo IdP to release a certain attribute if this is requested in the relay state. Just a wild idea that might be usefull in other situations.
There was a problem hiding this comment.
MKodde
approved these changes
Nov 6, 2024
pablothedude
force-pushed
the
feature/add-activation-flow-preference-test
branch
2 times, most recently
from
be0acb7 to
af5a4cd
Compare
MKodde
approved these changes
Nov 25, 2024
stepup/tests/behat/features/selfservice_activation_flow.feature
Outdated
Show resolved
Hide resolved
Add a test tom for the preferred activation flow query params
pablothedude
force-pushed
the
feature/add-activation-flow-preference-test
branch
from
4632e58 to
229e0ba
Compare
|
These changed are merged with: #22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test tom for the preferred activation flow query params
OpenConext/Stepup-SelfService#336