Use saml entitlement attribute for activation flow #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablothedude
force-pushed
the
feature/use-entiltlement-saml-attributes-for-activation-flow
branch
from
ac2a939 to
ede11a5
Compare
pablothedude
requested review from
MKodde and
parijke
and removed request for
MKodde
tvdijen
reviewed
Nov 1, 2024
|
|
||
| class ActivationFlowService | ||
| { | ||
| private const ACTIVATION_FLOW_PREFERENCE_SESSION_NAME = 'self_service_activation_flow_preference'; | ||
| private const ACTIVATION_FLOW_ENTITLEMENT_SAML_ATTRIBUTE = 'urn:mace:dir:attribute-def:eduPersonEntitlement'; |
There was a problem hiding this comment.
Please make this value configurable. We use a different attribute-name for our entitlements
There was a problem hiding this comment.
+1 for making the name of the entitlement attribute configurable.
There was a problem hiding this comment.
I've made it configurable
pablothedude
force-pushed
the
feature/use-entiltlement-saml-attributes-for-activation-flow
branch
from
e708f59 to
07173a5
Compare
MKodde
requested changes
Nov 6, 2024
There was a problem hiding this comment.
Awesome work. I see the new feature come to live and while at it you repair the damages being done by the introduction of the new SAML Authentcator.
Question: must you not enforce the preference in the activation wizard? When the user is presented how to activate its token. You now also have to consider the preference expressed in the SAML entitlement attribute right?
And see some suggestions below.
src/Surfnet/StepupSelfService/SelfServiceBundle/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
src/Surfnet/StepupSelfService/SelfServiceBundle/Security/Authentication/SamlAuthenticator.php
Show resolved
Hide resolved
src/Surfnet/StepupSelfService/SelfServiceBundle/Security/Authentication/SamlAuthenticator.php
Outdated
Show resolved
Hide resolved
src/Surfnet/StepupSelfService/SelfServiceBundle/Service/ActivationFlowService.php
Outdated
Show resolved
Hide resolved
src/Surfnet/StepupSelfService/SelfServiceBundle/Service/ActivationFlowService.php
Show resolved
Hide resolved
src/Surfnet/StepupSelfService/SelfServiceBundle/Service/ActivationFlowService.php
Outdated
Show resolved
Hide resolved
Use the saml entitlement attribute to allow the activation flow. If no activation could be allowed this will still result in service desk vetting. Also fixed the handling of imcoming query params which were not handled correctly because the StepupSamlBundle handles the authentication and the acivation flow param was therefore lost after entering first on the consume-assertion endpoint in the application. https://www.pivotaltracker.com/n/projects/1163646/stories/185558419
pablothedude
force-pushed
the
feature/use-entiltlement-saml-attributes-for-activation-flow
branch
from
07173a5 to
6b4ed2b
Compare
pablothedude
deleted the
feature/use-entiltlement-saml-attributes-for-activation-flow
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the saml entitlement attribute to allow the activation flow.
If no activation could be allowed this will still result in service
desk vetting.
https://www.pivotaltracker.com/n/projects/1163646/stories/185558419
OpenConext/OpenConext-devconf#17