Add ERC1155 mixin #941
Merged
Add ERC1155 mixin #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericnordelo
approved these changes
Mar 8, 2024
Co-authored-by: Eric Nordelo <[email protected]>
ericnordelo
reviewed
Mar 13, 2024
CHANGELOG.md
Outdated
| @@ -11,7 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| ### Added | |||
|
|
|||
| - ERC1155 component and preset (#896) | |||
| - Mixin implementations in components (#863) | |||
There was a problem hiding this comment.
We need to move this now to the Unreleased section.
There was a problem hiding this comment.
I created a separate entry specifically for ERC115 and ERC1155Receiver in Unreleased
ericnordelo
reviewed
Mar 13, 2024
4 tasks
martriay
reviewed
Mar 20, 2024
| @@ -61,7 +62,7 @@ mod ERC1155ReceiverComponent { | |||
| +HasComponent<TContractState>, | |||
| +SRC5Component::HasComponent<TContractState>, | |||
| +Drop<TContractState> | |||
| > of IERC1155ReceiverCamel<ComponentState<TContractState>> { | |||
| > of interface::IERC1155ReceiverCamel<ComponentState<TContractState>> { | |||
There was a problem hiding this comment.
any reason to make this explicit here?
There was a problem hiding this comment.
The mixin requires another import from erc1155::interface. I figured it's better to just use the single interface mod rather than bringing three interfaces into scope. No strong preference though
There was a problem hiding this comment.
but didn't the previous version imported only the ones it used? I lean towards dropping interface:: from these impl definitions to improve readability
martriay
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #933.
PR Checklist