-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Change default storage to localStorage+cookie, store client session props #906
Conversation
Size Change: +777 B (0%) Total Size: 746 kB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Pulled and ran locally and it migrated me to localStorage+cookie
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wat. This already supports migrating? I had no idea :D
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to pull out the changed default stuff only and not the client_session_props.
Reason being - we might need to reconsider the approach given what we are learning about the cookie size and content potentially triggering things like Cloudflares security challenges
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
This PR was closed due to lack of activity. Feel free to reopen if it's still relevant. |
Changes
Didn't need to change much as the localStorage+cookie already handles the migration! Just needed to change the default, sanity check that tests work, and add my own key to the list of cookie-persisted keys.
Supercedes: #875
Related to: https://github.com/PostHog/product-internal/pull/531 and #876
Before we merge, let's merge this first PostHog/posthog.com#7095 and make sure that nothing catches fire
Checklist