Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Swap to localstorage+cookie as default #927

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

benjackwhite
Copy link
Collaborator

Changes

Pulled out of #906 to make only the change to the default storage

Checklist

Copy link

github-actions bot commented Dec 7, 2023

Size Change: +765 B (0%)

Total Size: 746 kB

Filename Size Change
dist/array.full.js 176 kB +192 B (0%)
dist/array.js 118 kB +191 B (0%)
dist/es.js 118 kB +191 B (0%)
dist/module.js 118 kB +191 B (0%)
ℹ️ View Unchanged
Filename Size
dist/exception-autocapture.js 12 kB
dist/recorder-v2.js 104 kB
dist/recorder.js 58.4 kB
dist/surveys.js 41.5 kB

compressed-size-action

@benjackwhite benjackwhite marked this pull request as ready for review December 7, 2023 16:23
Copy link
Collaborator

@mariusandra mariusandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@benjackwhite benjackwhite added the bump minor Bump minor version when this PR gets merged label Dec 8, 2023
@benjackwhite benjackwhite merged commit 8327864 into master Dec 8, 2023
13 checks passed
@benjackwhite benjackwhite deleted the feat/default-localstorage-plus-cookie branch December 8, 2023 07:34
evanfreeze added a commit to evanfreeze/posthog.com that referenced this pull request Nov 15, 2024
As of PostHog/posthog-js#927 and the subsequent release of 1.94.0 ([changelog entry](https://github.com/PostHog/posthog-js/blob/main/CHANGELOG.md#1940---2023-12-08)), `localStorage+cookie` is the default persistence value. 

It looks like this got updated in the "Persistence" section, where it says "localStorage+cookie (default)" but didn't get updated in this "Config" section.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump minor Bump minor version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants