Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #241 - add min-content for alert container #245

Merged
merged 9 commits into from
Nov 28, 2023
Merged

fix: #241 - add min-content for alert container #245

merged 9 commits into from
Nov 28, 2023

Conversation

mattgoud
Copy link
Collaborator

❓ Types of changes

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • 📦 New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes
  • The component exists on old Prestashop UIKit and my pull request on migrating documentation is accepted.

@mattgoud mattgoud linked an issue Nov 14, 2023 that may be closed by this pull request
[BUG] [ALERT] incorrect responsive behavior (button position) #241
Closed
@mattgoud mattgoud requested a review from MrBaiame November 28, 2023 12:50
MrBaiame
MrBaiame previously approved these changes Nov 28, 2023
View reviewed changes
@mattgoud mattgoud requested a review from MrBaiame November 28, 2023 13:17
@mattgoud mattgoud merged commit 593026a into main Nov 28, 2023
2 checks passed
@mattgoud mattgoud deleted the bug/alert-incorrect-responsive-behavior branch November 28, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrBaiame MrBaiame MrBaiame approved these changes

@cnavarro-prestashop cnavarro-prestashop cnavarro-prestashop left review comments

@aAmorim27 aAmorim27 Awaiting requested review from aAmorim27

@MikeLebeau MikeLebeau Awaiting requested review from MikeLebeau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] [ALERT] incorrect responsive behavior (button position)
3 participants
@mattgoud @MrBaiame @cnavarro-prestashop