Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #241 - add min-content for alert container #245

Merged
merged 9 commits into from
Nov 28, 2023
Merged

fix: #241 - add min-content for alert container #245

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e2b85be
fix: #241 - add min-content for alert container
mattgoud Nov 14, 2023
2edef55
Merge branch 'main' into bug/alert-incorrect-responsive-behavior
mattgoud Nov 14, 2023
cfd90f4
Merge branch 'main' into bug/alert-incorrect-responsive-behavior
mattgoud Nov 14, 2023
e1e18de
fix: #241 - min height for button component
mattgoud Nov 14, 2023
4017fa7
Merge branch 'main' into bug/alert-incorrect-responsive-behavior
mattgoud Nov 28, 2023
d28c6b6
feat: [button/alert] add button label wrap prop
mattgoud Nov 28, 2023
de8a269
Merge branch 'bug/alert-incorrect-responsive-behavior' of github.com:…
mattgoud Nov 28, 2023
912ad53
feat: [button/alert] - wrap button label set tofalse by default
mattgoud Nov 28, 2023
df78e26
docs: [alert] update storybook
mattgoud Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/tailwind-preset/theme.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,11 @@ module.exports = {
screens: {
xs: '320px',
},
minHeight: {
sm: '1.75rem',
md: '2.25rem',
lg: '3rem',
},
opacity: {
overlay: '0.8',
},
Expand Down
6 changes: 3 additions & 3 deletions packages/theme/src/alert.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
@use './common/typography.scss';

.puik-alert {
@apply relative flex flex-row p-4 border text-primary-800 items-start;
@apply relative min-w-fit flex flex-row items-start p-4 border text-primary-800;
&--success {
@apply bg-green-50 border border-green;
.puik-alert__icon {
Expand Down Expand Up @@ -30,7 +30,7 @@
@apply border-0;
}
&__container {
@apply flex flex-col md:flex-row w-full;
@apply flex flex-col md:flex-row md:items-start w-full;
}
&__content {
@apply flex flex-row flex-grow;
Expand All @@ -46,7 +46,7 @@
@extend .puik-body-default;
}
&__button {
@apply text-sm px-4 py-3 mt-2 ml-9 md:m-0;
@apply mt-2 ml-9 md:m-0;
}
&__icon {
@apply mt-0.5 flex-shrink-0;
Expand Down
6 changes: 3 additions & 3 deletions packages/theme/src/button.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,16 @@

&--sm {
@extend .puik-text-button-small;
@apply py-1 px-2 h-7;
@apply py-1 px-2 min-h-sm;
}

&--md {
@apply h-9;
@apply min-h-md;
}

&--lg {
@extend .puik-text-button-large;
@apply py-3.5 px-4 gap-3 h-12;
@apply py-3.5 px-4 gap-3 min-h-lg;
}

&--fluid {
Expand Down
Loading