-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace mass shifts in peptide proforma strings during FragPipe and Sage parsing with modification names #444
Comments
Yes, we decided not to homogenise the modifications at this stage. We can totally discuss changing this. |
I see, that makes total sense. If we only look at the total number of peptidoforms it doesn't matter at all. |
It never hurts to improve the code ;) |
Two more differences I ran into: |
As Robbin already predicted, simply replacing the mass shifts with the modification names does not always work due to differences in precision. I have a sage file now where Carbamidomethylation is "+57.021465" instead of just "+57.0215", leading to the replacing not working. |
Fixed temporarily in commit 7ed16c4, but we might need something more sophisticated for the future |
Might be a bug, modifications are still reported as mass shifts in FragPipe (e.g. "AC[[57.0215]]FHC[[57.0215]]ETC[[57.0215]]K|Z=3") and Sage (e.g. "AAAIGIDLGTTYSC[[+57.0215]]VGVFQHGK|Z=3
") result tables while in MaxQuant and AlphaPept, they are reported with names (e.g. "AAC[Carbamidomethyl]LPLPGYR|Z=2.0
"). The replacement dicts are already in the .toml.
The text was updated successfully, but these errors were encountered: