This repository has been archived by the owner on Apr 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 120
Fix/traversability ghost obstacles #892
Open
VAM7686
wants to merge
33
commits into
master
Choose a base branch
from
fix/traversability_ghost_obstacles
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think that it is fine for these values to be zero because on the real robot the yostlab driver can add an offset which allows for the IMU to report zero when facing east. Thus, having the simulated IMUs report zero when facing east should be fine.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes ghost obstacles in traversability layer by applying morphological transforms.
This PR does the following:
Fixes #836
Testing steps (If relevant)
Test Case 1
roslaunch igvc_gazebo ramp_lane.launch
roslaunch igvc_navigation navigation_simulation.launch
Expectation: Robot able to navigate over ramp smoothly without any ghost obstacles.
Self Checklist
make format