-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYNPY-1332] Pypi deployment strategy #1038
Conversation
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Nice! I will pre-approve, but can we add instructions to the confluence page / contributing docs about the OIDC integration which also allows us to remove some of the GitHub secrets?
@thomasyu888 I added this to our Confluence docs here: https://sagebionetworks.jira.com/wiki/spaces/SYNPY/pages/65503359/Python+Client+Developer+Bootstrap#Deployment-to-PyPi |
Problem:
Solution:
build
instead of runningsetup.py
Testing:
setup.py
changes. This was uploaded after thesetup.py
changes.I verified that I could install the dependency and I was able to use the command line
synapse login
: