Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYNPY-1332] Pypi deployment strategy #1038

Merged
merged 10 commits into from
Jan 3, 2024

Conversation

BryanFauble
Copy link
Contributor

Problem:

  1. We need to harden the pypi deployment strategy
  2. We need to migrate away from using setup.py

Solution:

  1. Implemented this GH action: https://github.com/pypa/gh-action-pypi-publish
  2. Update to use build instead of running setup.py

Testing:

  1. Verified that I could deploy artifacts out to test pypi. This was uploaded without the setup.py changes. This was uploaded after the setup.py changes.
  2. I installed the artifacts via:
pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple synapseclient==3.2.1.1959
pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple synapseclient==3.2.1.1961

I verified that I could install the dependency and I was able to use the command line synapse login:

> synapse login

Welcome, Bryan Fauble!

Logged in as: bfauble (3481671)

@BryanFauble BryanFauble requested a review from a team as a code owner January 2, 2024 23:33
Copy link

sonarqubecloud bot commented Jan 3, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Nice! I will pre-approve, but can we add instructions to the confluence page / contributing docs about the OIDC integration which also allows us to remove some of the GitHub secrets?

@BryanFauble
Copy link
Contributor Author

✅ Nice! I will pre-approve, but can we add instructions to the confluence page / contributing docs about the OIDC integration which also allows us to remove some of the GitHub secrets?

@thomasyu888 I added this to our Confluence docs here: https://sagebionetworks.jira.com/wiki/spaces/SYNPY/pages/65503359/Python+Client+Developer+Bootstrap#Deployment-to-PyPi

@BryanFauble BryanFauble merged commit e3782f1 into develop Jan 3, 2024
38 checks passed
@BryanFauble BryanFauble deleted the SYNPY-1332-pypi-deployment-strategy branch January 3, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants