Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYNPY-1332] Pypi deployment strategy #1038

Merged
merged 10 commits into from
Jan 3, 2024
Merged

[SYNPY-1332] Pypi deployment strategy #1038

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6e5ef7f
Replace deploy to pypi with GH action
BryanFauble Dec 30, 2023
a89609d
Use environment context
BryanFauble Dec 30, 2023
9fe26ca
Correct workflow
BryanFauble Dec 30, 2023
76fdda3
Update deployment
BryanFauble Dec 30, 2023
ef3e40c
Change repo url
BryanFauble Dec 30, 2023
0afb07d
Changing conditional
BryanFauble Dec 30, 2023
2f207ad
different jobs for prod/test
BryanFauble Dec 30, 2023
4a7e728
Change if condition
BryanFauble Dec 30, 2023
4fb3164
Swap pip install
BryanFauble Dec 30, 2023
8e9307a
Revert temp changes
BryanFauble Dec 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 17 additions & 45 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,12 +276,13 @@ jobs:
python3 -m pip install --upgrade pip
python3 -m pip install setuptools
python3 -m pip install wheel
python3 -m pip install build

# install synapseclient
python3 setup.py install
python3 -m pip install .

# create distribution
python3 setup.py sdist bdist_wheel
python3 -m build

SDIST_PACKAGE_NAME="synapseclient-${{env.VERSION}}.tar.gz"
BDIST_PACKAGE_NAME="synapseclient-${{env.VERSION}}-py3-none-any.whl"
Expand Down Expand Up @@ -334,15 +335,13 @@ jobs:
# we upload prereleases to test.pypi.org and releases to pypi.org.
deploy:
needs: package

runs-on: ubuntu-20.04

runs-on: ubuntu-latest
environment:
url: ${{ github.event.release.prerelease == 'true' && 'https://test.pypi.org/p/synapseclient' || 'https://pypi.org/p/synapseclient' }}
name: pypi
permissions:
id-token: write
steps:

- uses: actions/setup-python@v4
with:
python-version: 3.8

- name: download-sdist
uses: actions/download-artifact@v2
with:
Expand All @@ -354,41 +353,14 @@ jobs:
with:
name: ${{ needs.package.outputs.bdist-package-name }}
path: dist

- name: deploy-to-pypi
shell: bash
run: |
python3 -m pip install twine

if [[ "${{ github.event.release.prerelease}}" == "false" ]]; then
# production deploy to prod pypi server

PYPI_NAME="pypi"
PYPI_URL="https://pypi.org"
PYPI_REPO="https://upload.pypi.org/legacy/"
PYPI_USERNAME="${{ secrets.PYPI_PROD_USERNAME }}"
PYPI_PASSWORD="${{ secrets.PYPI_PROD_PASSWORD }}"
else
# staging deploy to test pypi server

PYPI_NAME=testpypi
PYPI_URL="https://test.pypi.org"
PYPI_REPO=https://test.pypi.org/legacy/
PYPI_USERNAME="${{ secrets.PYPI_TEST_USERNAME }}"
PYPI_PASSWORD="${{ secrets.PYPI_TEST_PASSWORD }}"
PYPI_INDEX_URL="https://test.pypi.org/simple/"
fi

# create .pypirc file
echo "[distutils]" > ~/.pypirc
echo "index-servers=$PYPI_NAME" >> ~/.pypirc
echo >> ~/.pypirc
echo "[$PYPI_NAME]" >> ~/.pypirc
echo "repository: $PYPI_REPO" >> ~/.pypirc
echo "username:$PYPI_USERNAME" >> ~/.pypirc
echo "password:$PYPI_PASSWORD" >> ~/.pypirc

twine upload --repository $PYPI_NAME dist/*
- name: deploy-to-test-pypi
if: 'github.event.release.prerelease'
uses: pypa/gh-action-pypi-publish@release/v1
with:
repository-url: https://test.pypi.org/legacy/
- name: deploy-to-prod-pypi
if: '!github.event.release.prerelease'
uses: pypa/gh-action-pypi-publish@release/v1

# on each of our matrix platforms, download the newly uploaded package from pypi and confirm its version
check-deploy:
Expand Down
Loading