Sequester realm export (memory only implementation) #9342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
touilleMan
force-pushed
the
sequester-export-memory-only
branch
2 times, most recently
from
ec6ceb2 to
e5ea163
Compare
touilleMan
changed the base branch from
master
to
sequester-with-key-rotation
touilleMan
force-pushed
the
sequester-export-memory-only
branch
from
e5ea163 to
7d741e5
Compare
AureliaDolo
reviewed
Jan 15, 2025
| # indexes (e.g. when a transaction is rolled back). | ||
| # This should be enough to detect typical improper use of the primary key as | ||
| # a list offset. | ||
| return enumerate(all_vlob_atoms, start=200) |
There was a problem hiding this comment.
Is there a specific reason to start at 200 here and at 100 in simulate_postgresql_block_table above ?
There was a problem hiding this comment.
The start value is totally arbitrary since its goal is only to detect typical improper use of the primary key as a list offset.
Having different arbitrary offsets is convenient to help debugging since it makes values more unique.
| assert response.status_code == 404, response.content | ||
|
|
||
|
|
||
| # async def test_ok( |
There was a problem hiding this comment.
Good catch !
I've added tests to sequester administration APIs
There was a problem hiding this comment.
Yes, this is the python way of declaring the sequester_export folder is a module
8 tasks
…ate/administration_organization_sequester_service_revoke/administration_organization_sequester_service_update_config
…uester create/revoke
touilleMan
force-pushed
the
sequester-export-memory-only
branch
from
8479d36 to
519499b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #6644