Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor 0.8.5-rc1 fixes, syncing translations and screenshots repos #661

Merged
merged 6 commits into from
Jan 19, 2025

Conversation

kdmukai
Copy link
Contributor

@kdmukai kdmukai commented Jan 14, 2025

Description

  • First use of named variables in the English source string (see: tools_screens.py; line 187, ES messages.po; line 572)
    • Allows for translators to change the order that the variable substitution will occur in the translated sentence.
    • Also allows translators to omit variables when space is limited.
    • Fully supported in the Transifex UI.
  • Adds one English string ("Electrum seeds") that had not been marked for translation in 0.8.5-rc1.
  • Adds updated messages.pot (the master source of truth for English source strings).
  • Returns .gitmodules to point the translations repo's dev branch.
  • Syncs seedsigner-translations and seedsigner-screenshots submodules to point to their current commits.
    • Annoyingly and confusingly, the .gitmodules file isn't where the real action takes place; git submodules actually track a specific commit hash to the child submodule that has to be explicitly updated in the parent repo whenever a child has changed.
    • The branch option in .gitmodules only matters when the parent calls git submodule update --recursive --remote to update its commit hashes to its submodule children.
    • see: https://superuser.com/a/1601787

This pull request is categorized as a:

  • Other (missing translation, submodule repo syncing)

Checklist

  • I’ve run pytest and made sure all unit tests pass before sumbitting the PR

If you modified or added functionality/workflow, did you add new unit tests?

  • N/A

I have tested this PR on the following platforms/os:

@newtonick
Copy link
Collaborator

ACK, Reviewed and Tested.

I was able to generate identical messages.mo files based on the messages.po files included in seedsigner-translate.

I was not able to create identical seedsigner-screenshot files. However visually they are identical.

@newtonick newtonick merged commit cbaaaf4 into SeedSigner:dev Jan 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged Not Yet Released
Development

Successfully merging this pull request may close these issues.

2 participants