Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registering Fixes #14

Merged
merged 7 commits into from
Dec 2, 2024
Merged

Registering Fixes #14

merged 7 commits into from
Dec 2, 2024

Conversation

JakeGBLP
Copy link

@JakeGBLP JakeGBLP commented Dec 1, 2024

Added checks to avoid registering ClassInfos when another plugin already does so which causes incompatibilities.

eyesniper2
eyesniper2 reviewed Dec 2, 2024
View reviewed changes
Copy link

@eyesniper2 eyesniper2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Just left some comments around styling. Once those are fixed, it looks good to merge!

src/main/java/com/shanebeestudios/skbee/elements/objective/type/Types.java Outdated Show resolved Hide resolved
src/main/java/com/shanebeestudios/skbee/elements/other/type/Types.java Outdated Show resolved Hide resolved
src/main/java/com/shanebeestudios/skbee/elements/other/type/Types.java Show resolved Hide resolved
src/main/java/com/shanebeestudios/skbee/elements/other/type/Types.java Outdated Show resolved Hide resolved
src/main/java/com/shanebeestudios/skbee/elements/text/type/Types.java Outdated Show resolved Hide resolved
src/main/java/com/shanebeestudios/skbee/elements/particle/type/Types.java Show resolved Hide resolved
src/main/java/com/shanebeestudios/skbee/elements/particle/type/Types.java Show resolved Hide resolved
@ShaneBeee
Copy link
Collaborator

ShaneBeee commented Dec 2, 2024 •
edited
Loading

I'm not sure what happened here but I noticed tests were failing.
So I decided to checkout your PR in IJ, and I think some brackets may have gotten screwed up somewhere.
Im assuming there was a suggestion which you committed, and maybe that suggestion broke something here or there.

Screenshot 2024-12-02 at 10 20 42 AM

EDIT:
Ok ignore my message, I just went ahead and fixed those

@ShaneBeee ShaneBeee changed the base branch from master to dev/update December 2, 2024 18:43
ShaneBeee
ShaneBeee approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@ShaneBeee ShaneBeee left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you for your contribution.

@ShaneBeee ShaneBeee merged commit 142596b into SkriptHub:dev/update Dec 2, 2024
2 checks passed
@ShaneBeee ShaneBeee mentioned this pull request Dec 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyesniper2 eyesniper2 eyesniper2 left review comments

@ShaneBeee ShaneBeee ShaneBeee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JakeGBLP @ShaneBeee @eyesniper2