-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test/demeter balancer #17
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged from wip/demeter-balancer
bayou020
requested review from
TechnoGeek01,
arcantheon,
YashP16 and
parv3213
October 27, 2023 11:49
parv3213
reviewed
Nov 1, 2023
parv3213
reviewed
Nov 1, 2023
parv3213
reviewed
Nov 1, 2023
parv3213
reviewed
Nov 1, 2023
parv3213
reviewed
Nov 1, 2023
Co-authored-by: Parv Garg <[email protected]>
Not related to this PR, but |
Commendable work @bayou020 👏 .
|
arcantheon
reviewed
Nov 14, 2023
arcantheon
reviewed
Nov 14, 2023
arcantheon
reviewed
Nov 14, 2023
arcantheon
reviewed
Nov 14, 2023
arcantheon
reviewed
Nov 14, 2023
arcantheon
reviewed
Nov 14, 2023
arcantheon
requested changes
Nov 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve the comments
- Fixed RevertsWhen Naming convetion - Fixed ExpectEmit Failed assertions - Added Maths tests
Added Maths tests for increase Deposit and withdraw Partially functions
- Added a check on Farm ID - Added Deposit Maths check
test_deposit_noLockupFarm_revertsWhen_NoLiquidityInPosition fix
parv3213
reviewed
Nov 16, 2023
arcantheon
approved these changes
Nov 16, 2023
YashP16
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added BaseFarm Test cases