enhance: CMD-182 design tokens #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleyboar
force-pushed
the
enhance/CMD-182-design-tokens
branch
from
6c24842 to
83c5bff
Compare
wesleyboar
changed the title
-rgb css vars
wesleyboar
changed the title
%x-overlay--callout already does this
- not supported by Safari v15* - not polyfilled by postcss-relative-color-syntax * Supported by v16. Once v18 coems ut, we can use var in rgb, because we only need support latest 2 major versions of common browsers.
wesleyboar
force-pushed
the
enhance/CMD-182-design-tokens
branch
from
39a2e10 to
9ea6f96
Compare
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Do not use
-rgbCSS variables. Update%x-overlayusage. Deprecatealt/weakcolors.Related
Changes
%x-overlayto override latest properties%x-overlayusages to use design tokensTesting
Verify homepage
%x-overlayusage's color and opacity are unchanged on:UI
Skipped.