-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: CMD-182 design tokens #372
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
enhancement
Improvements or additions to existing features
label
Aug 23, 2024
wesleyboar
added
minor
A feature in backward-compatible manner
major
An incompatible API change
and removed
minor
A feature in backward-compatible manner
labels
Aug 23, 2024
wesleyboar
changed the title
feat: CMD-182 save v3 design tokens
enhance: CMD-182 design tokens
Aug 23, 2024
2 tasks
`format('style-dictionary3')` Must I find/replace every time I update tokens? Grumble.
- not supported by Safari v15* - not polyfilled by postcss-relative-color-syntax * Supported by v16. Once v18 coems ut, we can use var in rgb, because we only need support latest 2 major versions of common browsers.
- not supported by Safari v15* - not polyfilled by postcss-relative-color-syntax * Supported by v16. Once v18 coems ut, we can use var in rgb, because we only need support latest 2 major versions of common browsers.
* feat: CMD-182 use tokens core-v3 * build: CMD-182 tokens core-v3 light * chore: CMD-182 delete dist of deleted files * enhance: CMD-182 revise color grid - add fifth accent - flatten color token names * enhance: CMD-182 revise color grid - add fifth accent - flatten color token names * feat: deprecate alt/weak accent colors These are like the values TACC/tup-ui uses. * enhance: std message colors for portals * build: std message colors for portals * fix: CMD-182 revert color grid, keep new names * refactor: brand color tokens v1, v2, v3, ds * fix: CMD-182 revert from v3 to v2 (prep for merge) Prepare to merge to base, then return to v3 a smarter way. * chore: CMD-182 remove explicit v2 dist
All clients use the same colors now.
- Primitives: v1, v2, v3, ds - Tokens: dark, light
- Primitives: v1, v2, v3, ds - Tokens: dark, light
wesleyboar
added
minor
A feature in backward-compatible manner
and removed
major
An incompatible API change
labels
Sep 5, 2024
This was referenced Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Improvements or additions to existing features
minor
A feature in backward-compatible manner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add and use design tokens.
Important
Removed
--global-color-…-rgb
variables.No demo. Affected clients are updated via TACC/Core-CMS-Resources#200.
rgba(var(--global-color-…rgb), …)
rgb( from var(--global-color-…rgb) r g b / …)
Important
Changed Portal accent color from purple to blue.
Affected clients updated via TACC/tup-ui#476.
Important
Changed
--global-color-acent--light
from#86aeff
to#3d6acc
Status
.json
per Core-Styles version.ds
tokens to new projectRelated
Changes
build-tokens.js
, andbuild:tokens
NPM scriptbuild.js
tobuild-styles.js
--global-color-…-rgb
vars%x-overlay--callout
colors--portal.css
to use blue accentcolors.accent--*.css
colors.accent.v3.css
colors.v3.css
Testing & UI
UI
Skipped.
--global-color-acent--light
changed from#86aeff
to#3d6acc
.Build
tokens/*.json
.npm run buiild:css
.tokens/*.json
return with no changes.dist/
is unchanged.CMD-182.Build.mov