-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: CMD-182 design tokens core-v3 concept #375
Merged
wesleyboar
merged 14 commits into
enhance/CMD-182-design-tokens
from
enhance/CMD-182-design-tokens--v3-colors
Aug 27, 2024
Merged
feat: CMD-182 design tokens core-v3 concept #375
wesleyboar
merged 14 commits into
enhance/CMD-182-design-tokens
from
enhance/CMD-182-design-tokens--v3-colors
Aug 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
enhancement
Improvements or additions to existing features
label
Aug 23, 2024
This was referenced Aug 23, 2024
wesleyboar
changed the title
feat: CMD-182 use tokens core-v3
feat: CMD-182 design tokens core-v3
Aug 23, 2024
…ign-tokens--v3-colors
- add fifth accent - flatten color token names
- add fifth accent - flatten color token names
…:TACC/Core-Styles into enhance/CMD-182-design-tokens--v3-colors
These are like the values TACC/tup-ui uses.
Prepare to merge to base, then return to v3 a smarter way.
wesleyboar
changed the title
feat: CMD-182 design tokens core-v3
feat: CMD-182 design tokens core-v3 concept
Sep 5, 2024
wesleyboar
added a commit
that referenced
this pull request
Sep 5, 2024
* Initial tokens * Revert "Initial tokens" This reverts commit 0df274d. * Updates since adding v3 * feat: CMD-182 save v3 design tokens * fix: CMD-182 wrong tokens keys normal/medium * fix: CMD-182 token format v4 isntead of v3 `format('style-dictionary3')` Must I find/replace every time I update tokens? Grumble. * fix: CMD-182 token groups not unique, -xx to 2x * refactor: design-tokens, no rgb vars, rel. colors * docs: CMD-182 do not suggest var in rgb - not supported by Safari v15* - not polyfilled by postcss-relative-color-syntax * Supported by v16. Once v18 coems ut, we can use var in rgb, because we only need support latest 2 major versions of common browsers. * fix: CMD-182 do not use var in rgb - not supported by Safari v15* - not polyfilled by postcss-relative-color-syntax * Supported by v16. Once v18 coems ut, we can use var in rgb, because we only need support latest 2 major versions of common browsers. * fix: CMD-182 tokens core-v3 traffic * feat: CMD-182 tokens core-v3 light * build: CMD-182 tokens core-v2 light * feat: CMD-182 design tokens core-v3 (#375) * feat: CMD-182 use tokens core-v3 * build: CMD-182 tokens core-v3 light * chore: CMD-182 delete dist of deleted files * enhance: CMD-182 revise color grid - add fifth accent - flatten color token names * enhance: CMD-182 revise color grid - add fifth accent - flatten color token names * feat: deprecate alt/weak accent colors These are like the values TACC/tup-ui uses. * enhance: std message colors for portals * build: std message colors for portals * fix: CMD-182 revert color grid, keep new names * refactor: brand color tokens v1, v2, v3, ds * fix: CMD-182 revert from v3 to v2 (prep for merge) Prepare to merge to base, then return to v3 a smarter way. * chore: CMD-182 remove explicit v2 dist * docs: CMD-182 do not distinguish colors per client All clients use the same colors now. * chore: show deprecated colors as such in demo * fix: show deprecated colors as such in demo * fix: deprecated colors not loading * fix: deprecated colors not loading (v3) * chore: show more deprecated colors as such * fix: deprecated `on-light`/`dark` colors wrong * 2024-08-26 tokens - Primitives: v1, v2, v3, ds - Tokens: dark, light * (for real) 2024-08-26 tokens - Primitives: v1, v2, v3, ds - Tokens: dark, light * refactor: rename src/build to src/buuild-styles * renamed Primitive modes to match Token groups * fix: CMD-182 build tokens from single Figma export * chore: CMD-182 token build better logging * fix: CMD-182 token build excluding ever more data * feat: CMD-182 use new token files * fix: CMD-182 rgb relative color syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Improvements or additions to existing features
minor
A feature in backward-compatible manner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add Core v3 color tokens.
Important
Changes portal accent color from purple to blue.
Related
Changes
colors--portal.css
to use blue accentcolors.accent(…)css
to use design tokenscolors.accent--*.css
colors.accent.v3.css
colors.v3.css
Testing
Complicated.
UI
Skipped.