fix(electron): fix electron version of riscv64 #1959
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suyun114
force-pushed
the
fix-electron-version-riscv64
branch
from
202bb87 to
24974fe
Compare
kxxt
suggested changes
Jul 17, 2024
| @@ -26,11 +26,12 @@ if [[ "${VSCODE_ARCH}" == "riscv64" ]]; then | |||
| export VSCODE_ELECTRON_REPO='riscv-forks/electron-riscv-releases' | |||
| export ELECTRON_SKIP_BINARY_DOWNLOAD=1 | |||
| export PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD=1 | |||
| ELECTRON_VERSION="v29.4.0" | |||
| ELECTRON_VERSION="v30.2.0" | |||
There was a problem hiding this comment.
The version here should match .yarnrc to avoid native node module ABI breakage.
Upstream is still using v29.4.0. Is there any specific reason to bump to v30.2.0?
https://github.com/microsoft/vscode/blob/1.91.1/.yarnrc#L2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.